Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1640093002: Mac overlays: Isolate partial swap support (Closed)

Created:
4 years, 11 months ago by ccameron
Modified:
4 years, 11 months ago
Reviewers:
erikchen
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac overlays: Isolate partial swap support The logic to maintain a CALayer tree for partial swap support is complicated and should be removed, but that would compromise battery usage. Once the CoreAniamtion renderer is handling ~99% of the frames, we can remove it. In the mean time, isolate it. Create a CALayerPartialDamageTree to track the layer tree of partially swapped backbuffers. Do this in-place to minimize diffs, so that this patch can be reasonably reviewed. A follow-on patch will move it to a separate file. Slightly reorganize the logic so that CALayerPartialDamageTree matches the general structure of CALayerTree, where this a pending (not swapped) tree, a tree for each pending swap, and a tree for what is currently being displayed. BUG=533681 Committed: https://crrev.com/8aa00fc2a374fca3e9b9f34d838db7bb5f4fc088 Cr-Commit-Position: refs/heads/master@{#371831}

Patch Set 1 #

Patch Set 2 : Rename to partial damage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -113 lines) Patch
M content/common/gpu/image_transport_surface_overlay_mac.h View 1 5 chunks +3 lines, -14 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.mm View 1 14 chunks +143 lines, -99 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
ccameron
Paying penance for this monstrosity. Hopefully soon we can delete it and pretend it never ...
4 years, 11 months ago (2016-01-27 04:07:14 UTC) #2
erikchen
lgtm
4 years, 11 months ago (2016-01-27 16:41:14 UTC) #3
ccameron
Thanks!
4 years, 11 months ago (2016-01-27 18:40:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640093002/20001
4 years, 11 months ago (2016-01-27 18:42:28 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 18:50:25 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 18:51:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8aa00fc2a374fca3e9b9f34d838db7bb5f4fc088
Cr-Commit-Position: refs/heads/master@{#371831}

Powered by Google App Engine
This is Rietveld 408576698