Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1935)

Issue 1643043002: Mac overlays: Clean up partial swap code (Closed)

Created:
4 years, 10 months ago by ccameron
Modified:
4 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac overlays: Clean up partial swap code Remove use of linked_ptr, because it's not necessary now that we have C++11 support. Separate out functions to be a bit easier to read and follow. Remove unnecessary uses of RectF when Rect would do. BUG=533681 Committed: https://crrev.com/4d0aa96265cd731ddd74d43821df7feb9c55c1b1 Cr-Commit-Position: refs/heads/master@{#372707}

Patch Set 1 #

Patch Set 2 : Don't change vaidatlksdjf #

Total comments: 1

Patch Set 3 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -101 lines) Patch
M content/common/gpu/ca_layer_partial_damage_tree_mac.h View 1 2 2 chunks +15 lines, -7 lines 0 comments Download
M content/common/gpu/ca_layer_partial_damage_tree_mac.mm View 7 chunks +105 lines, -94 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ccameron
I think I can promise to be done with this now.
4 years, 10 months ago (2016-01-28 23:11:27 UTC) #2
erikchen
lgtm https://codereview.chromium.org/1643043002/diff/20001/content/common/gpu/ca_layer_partial_damage_tree_mac.h File content/common/gpu/ca_layer_partial_damage_tree_mac.h (right): https://codereview.chromium.org/1643043002/diff/20001/content/common/gpu/ca_layer_partial_damage_tree_mac.h#newcode38 content/common/gpu/ca_layer_partial_damage_tree_mac.h:38: // be updated this frame (and if it ...
4 years, 10 months ago (2016-01-29 04:20:14 UTC) #3
ccameron
Thanks!
4 years, 10 months ago (2016-02-01 17:43:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643043002/40001
4 years, 10 months ago (2016-02-01 17:43:43 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-01 18:54:55 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 18:56:09 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4d0aa96265cd731ddd74d43821df7feb9c55c1b1
Cr-Commit-Position: refs/heads/master@{#372707}

Powered by Google App Engine
This is Rietveld 408576698