content/browser/frame_host/navigation_request.h - Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.h

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't initialize NavigationHandle with base url for data url Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl_unittest.cc ('K') | « content/browser/frame_host/navigation_handle_impl_unittest.cc ('k') | content/browser/frame_host/navigation_request.cc » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_request.h

diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h

index 543cb6d48f5df872a9dde03a3d3b65f317b3f8bc..3892e180d3a3725dd7ce2298623e3721d671f754 100644

--- a/content/browser/frame_host/navigation_request.h

+++ b/content/browser/frame_host/navigation_request.h

@@ -129,7 +129,7 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {

// Creates a NavigationHandle. This should be called after any previous

// NavigationRequest for the FrameTreeNode has been destroyed.

Charlie Reis 2016/02/16 21:55:07 nit: Let's add a similar comment about the ID (and

Charlie Harrison 2016/02/16 22:55:22 Done.

- void CreateNavigationHandle();

+ void CreateNavigationHandle(int pending_nav_entry_id);

// Transfers the ownership of the NavigationHandle to |render_frame_host|.

// This should be called when the navigation is ready to commit, because the