Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't initialize NavigationHandle with base url for data url Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index e45133bcfd436322384ff0de177721e129c16fab..239703fc1c6184d0369a33f4eefd8851ef9401fc 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -227,14 +227,15 @@ void NavigationRequest::BeginNavigation() {
frame_tree_node_, nullptr, scoped_ptr<StreamHandle>());
}
-void NavigationRequest::CreateNavigationHandle() {
+void NavigationRequest::CreateNavigationHandle(int pending_nav_entry_id) {
// TODO(nasko): Update the NavigationHandle creation to ensure that the
// proper values are specified for is_synchronous and is_srcdoc.
navigation_handle_ =
NavigationHandleImpl::Create(common_params_.url, frame_tree_node_,
false, // is_synchronous
false, // is_srcdoc
- common_params_.navigation_start);
+ common_params_.navigation_start,
+ pending_nav_entry_id);
}
void NavigationRequest::TransferNavigationHandleOwnership(

Powered by Google App Engine
This is Rietveld 408576698