content/browser/frame_host/navigation_handle_impl_unittest.cc - Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl_unittest.cc

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't initialize NavigationHandle with base url for data url Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl_unittest.cc ('K') | « content/browser/frame_host/navigation_handle_impl.cc ('k') | content/browser/frame_host/navigation_request.h » ('j') | content/browser/frame_host/navigation_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_handle_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_handle_impl_unittest.cc b/content/browser/frame_host/navigation_handle_impl_unittest.cc

index d736e686699e4a13d44c115335c8d5d75a1cc2d9..c5cb97fb6a49bec6c93247d2422b4846396c8336 100644

--- a/content/browser/frame_host/navigation_handle_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_handle_impl_unittest.cc

@@ -66,7 +66,7 @@ class NavigationHandleImplTest : public RenderViewHostImplTestHarness {

RenderViewHostImplTestHarness::SetUp();

test_handle_ = NavigationHandleImpl::Create(

GURL(), main_test_rfh()->frame_tree_node(), false, false,

- base::TimeTicks::Now());

+ base::TimeTicks::Now(), 0);

}

void TearDown() override {