Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1661143003: Next round of GrGLSLFragmentProcessor-derived class cleanup (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix overlength line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -168 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 4 chunks +5 lines, -17 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 5 chunks +13 lines, -11 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 5 chunks +6 lines, -17 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 7 chunks +20 lines, -34 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 9 chunks +17 lines, -27 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 7 chunks +17 lines, -28 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 8 chunks +12 lines, -22 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 10 months ago (2016-02-03 21:45:24 UTC) #4
egdaniel
lgtm
4 years, 10 months ago (2016-02-03 21:53:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661143003/20001
4 years, 10 months ago (2016-02-03 21:54:56 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-03 22:19:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661143003/20001
4 years, 10 months ago (2016-02-04 14:11:07 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 14:11:56 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bf536af15f4c176d3bef65b77b7592718bfd9068

Powered by Google App Engine
This is Rietveld 408576698