Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1658693006: Normalize the PEM format used in some certificate test data. (Closed)

Created:
4 years, 10 months ago by eroman
Modified:
4 years, 10 months ago
Reviewers:
mattm
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Normalize the PEM format used in some certificate test data. * The annotation for PEM block should precedes the block rather than follow it * Remove extra newline at end of file * Two newlines separate title Committed: https://crrev.com/cf72295f7d8d641940ad7300a65f37837af3736e Cr-Commit-Position: refs/heads/master@{#373094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+691 lines, -1380 lines) Patch
M net/data/parse_certificate_unittest/basic_constraints_ca_false.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/basic_constraints_ca_no_path.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/basic_constraints_ca_path_9.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/basic_constraints_negative_path.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/basic_constraints_not_ca.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/basic_constraints_path_too_large.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/basic_constraints_pathlen_255.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/basic_constraints_pathlen_256.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/basic_constraints_pathlen_not_ca.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/basic_constraints_unconsumed_data.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/cert_algorithm_not_sequence.pem View 1 chunk +3 lines, -5 lines 0 comments Download
M net/data/parse_certificate_unittest/cert_data_after_signature.pem View 2 chunks +3 lines, -5 lines 0 comments Download
M net/data/parse_certificate_unittest/cert_empty_sequence.pem View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/parse_certificate_unittest/cert_missing_signature.pem View 1 chunk +3 lines, -5 lines 0 comments Download
M net/data/parse_certificate_unittest/cert_not_sequence.pem View 1 chunk +2 lines, -4 lines 0 comments Download
M net/data/parse_certificate_unittest/cert_signature_not_bit_string.pem View 2 chunks +3 lines, -5 lines 0 comments Download
M net/data/parse_certificate_unittest/cert_skeleton.pem View 2 chunks +9 lines, -19 lines 0 comments Download
M net/data/parse_certificate_unittest/cert_version3.pem View 3 chunks +52 lines, -62 lines 0 comments Download
M net/data/parse_certificate_unittest/extension_critical.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extension_critical_0.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extension_critical_3.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extension_not_critical.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_basic_constraints.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_data_after_sequence.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_duplicate_key_usage.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_empty_sequence.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_extended_key_usage.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_key_usage.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_not_sequence.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_policies.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_real.pem View 2 chunks +1 line, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_subject_alt_name.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_unknown_critical.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/extensions_unknown_non_critical.pem View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/parse_certificate_unittest/tbs_explicit_v1.pem View 2 chunks +4 lines, -6 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_negative_serial_number.pem View 2 chunks +16 lines, -38 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem View 2 chunks +4 lines, -6 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_serial_number_26_octets.pem View 2 chunks +4 lines, -6 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v1.pem View 2 chunks +16 lines, -38 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v1_extensions.pem View 2 chunks +4 lines, -6 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v2_extensions.pem View 2 chunks +4 lines, -6 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v2_issuer_and_subject_unique_id.pem View 2 chunks +16 lines, -42 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v2_issuer_unique_id.pem View 2 chunks +16 lines, -40 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v2_no_optionals.pem View 2 chunks +16 lines, -38 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v3_all_optionals.pem View 2 chunks +19 lines, -48 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v3_data_after_extensions.pem View 2 chunks +4 lines, -6 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v3_extensions.pem View 2 chunks +18 lines, -42 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v3_extensions_not_sequence.pem View 2 chunks +4 lines, -6 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v3_no_optionals.pem View 2 chunks +16 lines, -38 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v3_real.pem View 6 chunks +53 lines, -78 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_v4.pem View 2 chunks +4 lines, -6 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_validity_both_generalized_time.pem View 2 chunks +16 lines, -38 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_validity_both_utc_time.pem View 2 chunks +16 lines, -38 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_validity_generalized_time_and_utc_time.pem View 2 chunks +16 lines, -38 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_validity_relaxed.pem View 2 chunks +25 lines, -27 lines 0 comments Download
M net/data/parse_certificate_unittest/tbs_validity_utc_time_and_generalized_time.pem View 2 chunks +16 lines, -38 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512.pem View 2 chunks +9 lines, -19 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-spki-params-null.pem View 2 chunks +9 lines, -19 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-unused-bits-signature.pem View 2 chunks +9 lines, -19 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-using-ecdh-key.pem View 2 chunks +9 lines, -19 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-using-ecmqv-key.pem View 2 chunks +9 lines, -19 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-using-rsa-algorithm.pem View 2 chunks +9 lines, -19 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-wrong-signature-format.pem View 2 chunks +9 lines, -19 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-secp384r1-sha256.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-secp384r1-sha256-corrupted-data.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/ecdsa-using-rsa-key.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha1.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha1-bad-key-der-length.pem View 2 chunks +7 lines, -17 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha1-bad-key-der-null.pem View 3 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha1-key-params-absent.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha1-using-pss-key-no-params.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha1-wrong-algorithm.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha256.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha256-key-encoded-ber.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha256-spki-non-null-params.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha256-using-ecdsa-algorithm.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pkcs1-sha256-using-id-ea-rsa.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pss-sha1-salt20.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pss-sha1-salt20-using-pss-key-no-params.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pss-sha1-salt20-using-pss-key-with-null-params.pem View 2 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pss-sha1-wrong-salt.pem View 3 chunks +10 lines, -20 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pss-sha256-mgf1-sha512-salt33.pem View 2 chunks +11 lines, -21 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pss-sha256-salt10.pem View 3 chunks +11 lines, -21 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pss-sha256-salt10-using-pss-key-with-params.pem View 4 chunks +12 lines, -22 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-pss-sha256-salt10-using-pss-key-with-wrong-params.pem View 4 chunks +12 lines, -22 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa-using-ec-key.pem View 2 chunks +9 lines, -19 lines 0 comments Download
M net/data/verify_signed_data_unittest/rsa2048-pkcs1-sha512.pem View 4 chunks +11 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
eroman
Fixes the weird formatting I had used to make it more consistent with our other ...
4 years, 10 months ago (2016-02-02 02:40:22 UTC) #3
mattm
lgtm
4 years, 10 months ago (2016-02-02 22:28:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658693006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658693006/1
4 years, 10 months ago (2016-02-02 23:57:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 00:18:30 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 00:20:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf72295f7d8d641940ad7300a65f37837af3736e
Cr-Commit-Position: refs/heads/master@{#373094}

Powered by Google App Engine
This is Rietveld 408576698