net/data/parse_certificate_unittest/cert_missing_signature.pem - Issue 1658693006: Normalize the PEM format used in some certificate test data.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/parse_certificate_unittest/cert_missing_signature.pem

Issue 1658693006: Normalize the PEM format used in some certificate test data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 This is an otherwise "valid" Certificate input for ParseCertificate(), however	1 This is an otherwise "valid" Certificate input for ParseCertificate(), however

2 it is missing the final field (signature).	2 it is missing the final field (signature).

3	3

4	4

5

6 -----BEGIN CERTIFICATE-----

7 MAgwAgUAMAIFAA==

8 -----END CERTIFICATE-----

9

10 $ openssl asn1parse -i < [CERTIFICATE]	5 $ openssl asn1parse -i < [CERTIFICATE]

11 0:d=0 hl=2 l= 8 cons: SEQUENCE	6 0:d=0 hl=2 l= 8 cons: SEQUENCE

12 2:d=1 hl=2 l= 2 cons: SEQUENCE	7 2:d=1 hl=2 l= 2 cons: SEQUENCE

13 4:d=2 hl=2 l= 0 prim: NULL	8 4:d=2 hl=2 l= 0 prim: NULL

14 6:d=1 hl=2 l= 2 cons: SEQUENCE	9 6:d=1 hl=2 l= 2 cons: SEQUENCE

15 8:d=2 hl=2 l= 0 prim: NULL	10 8:d=2 hl=2 l= 0 prim: NULL

	11 -----BEGIN CERTIFICATE-----

	12 MAgwAgUAMAIFAA==

	13 -----END CERTIFICATE-----

OLD	NEW