third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp - Issue 1657203003: Detemplatize SimplifiedBackwardsTextIterator::copyTextTo with BackwardsTextBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

Issue 1657203003: Detemplatize SimplifiedBackwardsTextIterator::copyTextTo with BackwardsTextBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@apply_forward_buffer

Patch Set: Replace ref parameters by ptr ones Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h » ('j') | third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp b/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

index 8f16b63c74f22c9bb4bd7ca4b48d0e097f4521fa..b49cfdd90c232e758c8ba638e35b701ed529a902 100644

--- a/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

@@ -380,8 +380,8 @@ static size_t findPlainTextInternal(CharacterIteratorAlgorithm<Strategy>& it, co

if (buffer.needsMoreContext()) {

for (SimplifiedBackwardsTextIteratorAlgorithm<Strategy> backwardsIterator(PositionTemplate<Strategy>::firstPositionInNode(it.ownerDocument()), PositionTemplate<Strategy>(it.currentContainer(), it.startOffset())); !backwardsIterator.atEnd(); backwardsIterator.advance()) {

- Vector<UChar, 1024> characters;

- backwardsIterator.copyTextTo(characters);

+ BackwardsTextBuffer characters;

+ backwardsIterator.copyTextTo(&characters);

buffer.prependContext(characters.data(), characters.size());

if (!buffer.needsMoreContext())

break;