Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: components/omnibox/browser/shortcuts_backend.h

Issue 1655933004: Refactor to share code between shortcuts tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shortcuts
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/shortcuts_backend.h
diff --git a/components/omnibox/browser/shortcuts_backend.h b/components/omnibox/browser/shortcuts_backend.h
index 1d4202ac338e1a15672ff63fe1497b5f20499b5d..6aa9a0334d5506605d850ef1d43509f8697af22b 100644
--- a/components/omnibox/browser/shortcuts_backend.h
+++ b/components/omnibox/browser/shortcuts_backend.h
@@ -27,7 +27,14 @@
#include "components/search_engines/search_terms_data.h"
#include "url/gurl.h"
+class ShortcutsBackend;
class TemplateURLService;
+struct TestShortcutInfo;
+
+void PopulateShortcutsBackendWithTestShortcutData(
+ scoped_refptr<ShortcutsBackend> backend,
+ TestShortcutInfo* db,
+ size_t db_size);
namespace history {
class HistoryService;
@@ -92,6 +99,10 @@ class ShortcutsBackend : public RefcountedKeyedService,
friend class ShortcutsProviderExtensionTest;
friend class ShortcutsProviderTest;
friend class ShortcutsBackendTest;
+ friend void PopulateShortcutsBackendWithTestShortcutData(
+ scoped_refptr<ShortcutsBackend> backend,
+ TestShortcutInfo* db,
+ size_t db_size);
Peter Kasting 2016/02/03 00:31:47 Does this let us unfriend any of the test classes?
rohitrao (ping after 24h) 2016/02/03 14:58:08 Yup, dropped what I could.
FRIEND_TEST_ALL_PREFIXES(ShortcutsBackendTest, EntitySuggestionTest);
enum CurrentState {

Powered by Google App Engine
This is Rietveld 408576698