Refactor to share code between shortcuts tests.

components/omnibox/browser/shortcuts_backend.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_BROWSER_SHORTCUTS_BACKEND_H_
 #define COMPONENTS_OMNIBOX_BROWSER_SHORTCUTS_BACKEND_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "base/scoped_observer.h"
 #include "base/sequenced_task_runner.h"
 #include "base/strings/string16.h"
 #include "base/synchronization/lock.h"
 #include "base/time/time.h"
 #include "components/history/core/browser/history_service_observer.h"
 #include "components/keyed_service/core/refcounted_keyed_service.h"
 #include "components/omnibox/browser/autocomplete_match.h"
 #include "components/omnibox/browser/shortcuts_database.h"
 #include "components/search_engines/search_terms_data.h"
 #include "url/gurl.h"
 
+class ShortcutsBackend;
 class TemplateURLService;
+struct TestShortcutInfo;
+
+void PopulateShortcutsBackendWithTestShortcutData(
+    scoped_refptr<ShortcutsBackend> backend,
+    TestShortcutInfo* db,
+    size_t db_size);
 
 namespace history {
 class HistoryService;
 class ShortcutsDatabase;
 };  // namespace history
 
 // This class manages the shortcut provider backend - access to database on the
 // db thread, etc.
 class ShortcutsBackend : public RefcountedKeyedService,
                          public history::HistoryServiceObserver {
@@ skipping 44 matching lines @@
   // Looks for an existing shortcut to match.destination_url that starts with
   // |text|.  Updates that shortcut if found, otherwise adds a new shortcut.
   void AddOrUpdateShortcut(const base::string16& text,
                            const AutocompleteMatch& match);
 
  private:
   friend class base::RefCountedThreadSafe<ShortcutsBackend>;
   friend class ShortcutsProviderExtensionTest;
   friend class ShortcutsProviderTest;
   friend class ShortcutsBackendTest;
+  friend void PopulateShortcutsBackendWithTestShortcutData(
+      scoped_refptr<ShortcutsBackend> backend,
+      TestShortcutInfo* db,
+      size_t db_size);

[Peter Kasting, 2016/02/03 00:31:47]

Does this let us unfriend any of the test classes?

[rohitrao (ping after 24h), 2016/02/03 14:58:08]

Yup, dropped what I could.

   FRIEND_TEST_ALL_PREFIXES(ShortcutsBackendTest, EntitySuggestionTest);
 
   enum CurrentState {
     NOT_INITIALIZED,  // Backend created but not initialized.
     INITIALIZING,     // Init() called, but not completed yet.
     INITIALIZED,      // Initialization completed, all accessors can be safely
                       // called.
   };
 
   typedef std::map<std::string, ShortcutMap::iterator> GuidMap;
@@ skipping 62 matching lines @@
   scoped_refptr<base::SequencedTaskRunner> main_runner_;
   scoped_refptr<base::SequencedTaskRunner> db_runner_;
 
   // For some unit-test only.
   bool no_db_access_;
 
   DISALLOW_COPY_AND_ASSIGN(ShortcutsBackend);
 };
 
 #endif  // COMPONENTS_OMNIBOX_BROWSER_SHORTCUTS_BACKEND_H_