Refactor to share code between shortcuts tests.

components/omnibox/browser/shortcuts_provider_test_util.h

Index: components/omnibox/browser/shortcuts_provider_test_util.h
diff --git a/components/omnibox/browser/shortcuts_provider_test_util.h b/components/omnibox/browser/shortcuts_provider_test_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..500c929102ae4625e9f0066c783a9c34668777ae
--- /dev/null
+++ b/components/omnibox/browser/shortcuts_provider_test_util.h
@@ -0,0 +1,66 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+#include <vector>
+
+#include "base/memory/ref_counted.h"
+#include "components/omnibox/browser/autocomplete_match.h"
+
+class ShortcutsBackend;
+class ShortcutsProvider;
+
+typedef std::pair<std::string, bool> ShortcutExpectedURLAndAllowedToBeDefault;

[Peter Kasting, 2016/02/03 00:31:47]

Why add the word "Shortcut" on the front of these two types?  Seems like it just
adds verbosity for no (or negative) clarity, and there aren't symbol conflicts
I'm aware of that would necessitate this.

Similarly, I think the names below could be briefer and clearer by omitting most
of the instances of "Shortcut" (e.g. struct TestData, void
PopulateShortcutsBackendWithTestData(), etc.)

Nit: Prefer type aliases to typedefs

[rohitrao (ping after 24h), 2016/02/03 14:58:08]

There are currently no symbol conflicts, but I am uncomfortable putting classes
named "TestData" and "ExpectedURLs" into the global namespace.  I think that's
asking for conflicts in the future.  I'd like to keep the "Shortcut" in
TestShortcutData, but I will shorten the "Populate" method name as you
suggested.  I've also dropped the "Shortcut" prefix from the typedefs.
Done.

+typedef std::vector<ShortcutExpectedURLAndAllowedToBeDefault>
+    ShortcutExpectedURLs;
+
+struct TestShortcutInfo {
+  TestShortcutInfo(std::string guid,
+                   std::string text,
+                   std::string fill_into_edit,
+                   std::string destination_url,
+                   std::string contents,
+                   std::string contents_class,
+                   std::string description,
+                   std::string description_class,
+                   ui::PageTransition transition,
+                   AutocompleteMatch::Type type,
+                   std::string keyword,
+                   int days_from_now,
+                   int number_of_hits);
+  ~TestShortcutInfo();
+
+  std::string guid;
+  std::string text;
+  std::string fill_into_edit;
+  std::string destination_url;
+  std::string contents;
+  std::string contents_class;
+  std::string description;
+  std::string description_class;
+  ui::PageTransition transition;
+  AutocompleteMatch::Type type;
+  std::string keyword;
+  int days_from_now;
+  int number_of_hits;
+};
+
+// Fills test data into the shortcuts backend.
+void PopulateShortcutsBackendWithTestShortcutData(
+    scoped_refptr<ShortcutsBackend> backend,
+    TestShortcutInfo* db,
+    size_t db_size);
+
+// Runs an autocomplete query on |text| with the provided
+// |prevent_inline_autocomplete| setting and checks to see that the returned
+// results' destination URLs match those provided. |expected_urls| does not
+// need to be in sorted order, but |expected_top_result| should be the top
+// match, and it should have inline autocompletion
+// |top_result_inline_autocompletion|.
+void RunShortcutsProviderTest(scoped_refptr<ShortcutsProvider> provider,
+                              const base::string16 text,
+                              bool prevent_inline_autocomplete,
+                              const ShortcutExpectedURLs& expected_urls,
+                              std::string expected_top_result,
+                              base::string16 top_result_inline_autocompletion);