Gamepad API for Android

content/browser/gamepad/gamepad_platform_data_fetcher_android.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_GAMEPAD_GAMEPAD_DATA_FETCHER_ANDROID_H_
+#define CONTENT_BROWSER_GAMEPAD_GAMEPAD_DATA_FETCHER_ANDROID_H_
+
+#include <jni.h>
+
+#include "base/android/jni_android.h"
+#include "base/synchronization/lock.h"
+#include "content/browser/gamepad/gamepad_data_fetcher.h"
+#include "content/browser/gamepad/gamepad_standard_mappings.h"
+#include "third_party/WebKit/public/platform/WebGamepads.h"
+
+namespace content {
+
+class GamepadPlatformDataFetcherAndroid : public GamepadDataFetcher {
+ public:
+  GamepadPlatformDataFetcherAndroid();
+  virtual ~GamepadPlatformDataFetcherAndroid();
+
+  // GamepadDataFetcher implementation.
+  virtual void GetGamepadData(blink::WebGamepads* pads,
+                              bool devices_changed_hint) OVERRIDE;
+  virtual void PauseHint(bool paused);

[jdduke (slow), 2014/03/07 23:16:39]

OVERRIDE?

[kbalazs, 2014/03/12 00:17:36]

Done.

+
+  // Called by GamepadAdapter (java).
+  void RefreshDevice(JNIEnv* env,

[jdduke (slow), 2014/03/07 23:16:39]

See .cc comments about how this function can be made static (and local to the
.cc file).

[kbalazs, 2014/03/12 00:17:36]

I think the jni generator only supports methods so I didn't change this.

[jdduke (slow), 2014/03/12 01:06:18]

ViewConfiguration
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/android/vie...
provides an example of how to use a static method local to a .cc file from Java.

+                     jobject obj,
+                     int index,
+                     bool connected,
+                     jstring id,
+                     jstring mapping,
+                     long timestamp,
+                     jfloatArray axes,
+                     jfloatArray buttons);
+
+  static bool RegisterGamepadAdapter(JNIEnv* env);
+
+ private:
+  // Data to fetch into.
+  blink::WebGamepads* data_;

[jdduke (slow), 2014/03/07 23:16:39]

I'm not sure we need to hold on to this reference. See comments in the .cc file.

[kbalazs, 2014/03/12 00:17:36]

I kept it as I think it makes more sense than passing back and forth.

[jdduke (slow), 2014/03/12 01:06:18]

Except, we're not passing "back and forth" as much as we're issuing a direct
request to populate a given entity.  This is a lot more clear than caching a
pointer to this object and issuing a request at some future point in time to
populate a field that is temporary.

+
+  // The java GamepadAdapter object.
+  base::android::ScopedJavaGlobalRef<jobject> j_gamepad_adapter_;

[jdduke (slow), 2014/03/07 23:16:39]

I'm not sure we need this either.  The call into the GamePadAdapter might as
well be static if we're going with a singleton.

[kbalazs, 2014/03/12 00:17:36]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(GamepadPlatformDataFetcherAndroid);
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_GAMEPAD_GAMEPAD_DATA_FETCHER_ANDROID_H_