DevTools: Fix sorting by type in network panel

DevTools: Fix sorting by type in network panel

Requests are sorted by mimetype when user sort Type.
Type is simplified now. So, create TypeComparator for simple type.

BUG=582939
Committed: https://crrev.com/6acb2352cba11d40107ca1d195731a3eefcc3146
Cr-Commit-Position: refs/heads/master@{#373724}

[kimwjdalsl, 2016-02-01 14:34:05]

kimwjdalsl@gmail.com changed reviewers:
+ dgozman@chromium.org

[kimwjdalsl, 2016-02-01 14:34:05]

Please review this patch.

[kimwjdalsl, 2016-02-03 13:01:35]

kimwjdalsl@gmail.com changed reviewers:
+ paulirish@chromium.org

[kimwjdalsl, 2016-02-03 13:07:55]

dgozman,
As you can see Issue 582939, they are no objection for this issue. Could you
review the patch?

[paulirish, 2016-02-03 23:21:40]

Curious what dgozman thinks, but I'd do this differently.

This currently mirrors the logic from 
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

I would move that logic into a displayType() on the NetworkRequest object.
Then you'd grab request.displayType() to use in the comparator and the
_renderTypeCell

dgozman, that sgty?

[kimwjdalsl, 2016-02-04 10:33:27]

I updated to avoid code duplication with paulirish's opinion.
Thanks for it.

[paulirish, 2016-02-04 10:55:15]

lgtm, but i defer to dgozman

[dgozman, 2016-02-04 21:49:35]

Sorry for delay. This is mostly good, but let's move presentation code to
presentation class NetworkDataGridNode.

https://codereview.chromium.org/1654063002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/1654063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:132:
displayType: function()
I'd move this method to NetworkDataGridNode.prototype instead.

[kimwjdalsl, 2016-02-04 23:05:11]

dgozman, Thanks for your tips.

https://codereview.chromium.org/1654063002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/1654063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:132:
displayType: function()
On 2016/02/04 21:49:35, dgozman wrote:
> I'd move this method to NetworkDataGridNode.prototype instead.

Done.

[dgozman, 2016-02-05 00:52:24]

lgtm

[kimwjdalsl, 2016-02-05 01:14:08]

The CQ bit was checked by kimwjdalsl@gmail.com

[kimwjdalsl, 2016-02-05 01:14:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
paulirish@chromium.org
Link to the patchset: https://codereview.chromium.org/1654063002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-02-05 01:15:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1654063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1654063002/40001

[commit-bot: I haz the power, 2016-02-05 02:30:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-05 02:31:22]

Description was changed from

==========
DevTools: Fix sorting by type in network panel

Requests are sorted by mimetype when user sort Type.
Type is simplified now. So, create TypeComparator for simple type.

BUG=582939
==========

to

==========
DevTools: Fix sorting by type in network panel

Requests are sorted by mimetype when user sort Type.
Type is simplified now. So, create TypeComparator for simple type.

BUG=582939

Committed: https://crrev.com/6acb2352cba11d40107ca1d195731a3eefcc3146
Cr-Commit-Position: refs/heads/master@{#373724}
==========

[commit-bot: I haz the power, 2016-02-05 02:31:23]

Patchset 3 (id:??) landed as
https://crrev.com/6acb2352cba11d40107ca1d195731a3eefcc3146
Cr-Commit-Position: refs/heads/master@{#373724}