Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1654063002: DevTools: Fix sorting by type in network panel (Closed)

Created:
4 years, 10 months ago by kimwjdalsl
Modified:
4 years, 10 months ago
Reviewers:
paulirish, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, limasdf, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix sorting by type in network panel Requests are sorted by mimetype when user sort Type. Type is simplified now. So, create TypeComparator for simple type. BUG=582939 Committed: https://crrev.com/6acb2352cba11d40107ca1d195731a3eefcc3146 Cr-Commit-Position: refs/heads/master@{#373724}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 2 3 chunks +33 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
kimwjdalsl
Please review this patch.
4 years, 10 months ago (2016-02-01 14:34:05 UTC) #2
kimwjdalsl
4 years, 10 months ago (2016-02-03 13:01:36 UTC) #4
kimwjdalsl
dgozman, As you can see Issue 582939, they are no objection for this issue. Could ...
4 years, 10 months ago (2016-02-03 13:07:55 UTC) #5
paulirish
Curious what dgozman thinks, but I'd do this differently. This currently mirrors the logic from ...
4 years, 10 months ago (2016-02-03 23:21:40 UTC) #6
kimwjdalsl
I updated to avoid code duplication with paulirish's opinion. Thanks for it.
4 years, 10 months ago (2016-02-04 10:33:27 UTC) #7
paulirish
lgtm, but i defer to dgozman
4 years, 10 months ago (2016-02-04 10:55:15 UTC) #8
dgozman
Sorry for delay. This is mostly good, but let's move presentation code to presentation class ...
4 years, 10 months ago (2016-02-04 21:49:35 UTC) #9
kimwjdalsl
dgozman, Thanks for your tips. https://codereview.chromium.org/1654063002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right): https://codereview.chromium.org/1654063002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js#newcode132 third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:132: displayType: function() On 2016/02/04 ...
4 years, 10 months ago (2016-02-04 23:05:11 UTC) #10
dgozman
lgtm
4 years, 10 months ago (2016-02-05 00:52:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654063002/40001
4 years, 10 months ago (2016-02-05 01:15:26 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-05 02:30:13 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 02:31:23 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6acb2352cba11d40107ca1d195731a3eefcc3146
Cr-Commit-Position: refs/heads/master@{#373724}

Powered by Google App Engine
This is Rietveld 408576698