Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 1654063002: DevTools: Fix sorting by type in network panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index 194f85df499ba430db604b47b47978ab3a4dac45..de2bd9cac4f253f42fb5a11ce4ea1e06b692fab9 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -48,6 +48,21 @@ WebInspector.NetworkDataGridNode._hoveredRowSymbol = Symbol("hoveredRow");
WebInspector.NetworkDataGridNode.prototype = {
/**
+ * @return {string}
+ */
+ displayType: function()
+ {
+ var mimeType = this._request.mimeType || this._request.requestContentType() || "";
+ var resourceType = this._request.resourceType();
+ var simpleType = resourceType.name();
+
+ if (resourceType == WebInspector.resourceTypes.Other || resourceType == WebInspector.resourceTypes.Image)
+ simpleType = mimeType.replace(/^(application|image)\//, "");
+
+ return simpleType;
+ },
+
+ /**
* @return {!WebInspector.NetworkRequest}
*/
request: function()
@@ -309,15 +324,7 @@ WebInspector.NetworkDataGridNode.prototype = {
*/
_renderTypeCell: function(cell)
{
- var mimeType = this._request.mimeType || this._request.requestContentType() || "";
- var resourceType = this._request.resourceType();
- var simpleType = resourceType.name();
-
- if (resourceType == WebInspector.resourceTypes.Other
- || resourceType == WebInspector.resourceTypes.Image)
- simpleType = mimeType.replace(/^(application|image)\//, "");
-
- cell.setTextAndTitle(simpleType);
+ cell.setTextAndTitle(this.displayType());
},
/**
@@ -602,6 +609,23 @@ WebInspector.NetworkDataGridNode.SizeComparator = function(a, b)
* @param {!WebInspector.NetworkDataGridNode} b
* @return {number}
*/
+WebInspector.NetworkDataGridNode.TypeComparator = function(a, b)
+{
+ var aSimpleType = a.displayType();
+ var bSimpleType = b.displayType();
+
+ if (aSimpleType > bSimpleType)
+ return 1;
+ if (bSimpleType > aSimpleType)
+ return -1;
+ return a._request.indentityCompare(b._request);
+}
+
+/**
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
WebInspector.NetworkDataGridNode.InitiatorComparator = function(a, b)
{
var aInitiator = a._request.initiatorInfo();
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698