third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 1654063002: DevTools: Fix sorting by type in network panel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 1654063002: DevTools: Fix sorting by type in network panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index 406dd1d03876848106a25670f01b0a4cfa4d6c90..928238a7071deb4a4543bb465b08a540b95125c2 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -628,7 +628,7 @@ WebInspector.NetworkLogView.prototype = {

this._sortingFunctions.scheme = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "scheme", false);

this._sortingFunctions.domain = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "domain", false);

this._sortingFunctions.remoteAddress = WebInspector.NetworkDataGridNode.RemoteAddressComparator;

- this._sortingFunctions.type = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "mimeType", false);

+ this._sortingFunctions.type = WebInspector.NetworkDataGridNode.TypeComparator;

this._sortingFunctions.initiator = WebInspector.NetworkDataGridNode.InitiatorComparator;

this._sortingFunctions.cookies = WebInspector.NetworkDataGridNode.RequestCookiesCountComparator;

this._sortingFunctions.setCookies = WebInspector.NetworkDataGridNode.ResponseCookiesCountComparator;

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ('k') | no next file » | no next file with comments »