third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('K') | « third_party/WebKit/Source/platform/text/CompressibleString.cpp ('k') | third_party/WebKit/Source/web/WebKit.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index 02bb02e23e9a9236e966b80896335740fd802589..48cca3cdcd7cedfefcbadf8e624d57e3535ab306 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -56,13 +56,13 @@

#include "modules/accessibility/AXObject.h"

#include "platform/Cursor.h"

#include "platform/FileChooser.h"

+#include "platform/Histogram.h"

#include "platform/KeyboardCodes.h"

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/exported/WrappedResourceRequest.h"

#include "platform/geometry/IntRect.h"

#include "platform/graphics/GraphicsLayer.h"

#include "platform/weborigin/SecurityOrigin.h"

-#include "public/platform/Platform.h"

#include "public/platform/WebCursorInfo.h"

#include "public/platform/WebFloatRect.h"

#include "public/platform/WebFrameScheduler.h"

@@ -868,7 +868,8 @@ bool ChromeClientImpl::shouldOpenModalDialogDuringPageDismissal(const DialogType

ASSERT_WITH_SECURITY_IMPLICATION(0 <= dismissal);

ASSERT_WITH_SECURITY_IMPLICATION(dismissal < static_cast<int>(WTF_ARRAY_LENGTH(kDismissals)));

- Platform::current()->histogramEnumeration("Renderer.ModalDialogsDuringPageDismissal", dismissal * WTF_ARRAY_LENGTH(kDialogs) + dialog, WTF_ARRAY_LENGTH(kDialogs) * WTF_ARRAY_LENGTH(kDismissals));

+ DEFINE_STATIC_LOCAL(EnumerationHistogram, dialogDismissalHistogram, ("Renderer.ModalDialogsDuringPageDismissal", WTF_ARRAY_LENGTH(kDialogs) * WTF_ARRAY_LENGTH(kDismissals)));

+ dialogDismissalHistogram.count(dismissal * WTF_ARRAY_LENGTH(kDialogs) + dialog);

String message = String("Blocked ") + kDialogs[dialog] + "('" + dialogMessage + "') during " + kDismissals[dismissal] + ".";

m_webView->mainFrame()->addMessageToConsole(WebConsoleMessage(WebConsoleMessage::LevelError, message));