third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp ('k') | third_party/WebKit/Source/modules/cachestorage/Cache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index dd7569f3e53c37b40a72e1da283df5298df1ab42..4e7161bce11e6d38453370fa7c64e6799d0b6b89 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -63,6 +63,7 @@

#include "core/xmlhttprequest/XMLHttpRequestUpload.h"

#include "platform/FileMetadata.h"

#include "platform/HTTPNames.h"

+#include "platform/Histogram.h"

#include "platform/Logging.h"

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/SharedBuffer.h"

@@ -71,7 +72,6 @@

#include "platform/network/ParsedContentType.h"

#include "platform/network/ResourceError.h"

#include "platform/network/ResourceRequest.h"

-#include "public/platform/Platform.h"

#include "public/platform/WebURLRequest.h"

#include "wtf/Assertions.h"

#include "wtf/StdLibExtras.h"

@@ -1206,7 +1206,8 @@ void XMLHttpRequest::setRequestHeaderInternal(const AtomicString& name, const At

if (!normalizedValue.isEmpty() && !isValidHTTPFieldContentRFC7230(normalizedValue))

headerValueCategory = HeaderValueInvalid;

- Platform::current()->histogramEnumeration("Blink.XHR.setRequestHeader.HeaderValueCategoryInRFC7230", headerValueCategory, HeaderValueCategoryByRFC7230End);

+ DEFINE_STATIC_LOCAL(EnumerationHistogram, headerValueCategoryHistogram, ("Blink.XHR.setRequestHeader.HeaderValueCategoryInRFC7230", HeaderValueCategoryByRFC7230End));

sof 2016/02/07 20:14:19 XHR can be used by the main thread and workers, so

tyoshino (SeeGerritForStatus) 2016/02/08 08:38:21 Just received a bug report: https://code.google.co

+ headerValueCategoryHistogram.count(headerValueCategory);

}

const AtomicString& XMLHttpRequest::getRequestHeader(const AtomicString& name) const