third_party/WebKit/Source/platform/text/CompressibleString.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/CompressibleString.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('K') | « third_party/WebKit/Source/platform/heap/Heap.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/text/CompressibleString.cpp

diff --git a/third_party/WebKit/Source/platform/text/CompressibleString.cpp b/third_party/WebKit/Source/platform/text/CompressibleString.cpp

index 38e6c09f41e1978f53a41ac1f73072b8307fd3ce..3b7f6c394ca847483967aeea680b931481344c80 100644

--- a/third_party/WebKit/Source/platform/text/CompressibleString.cpp

+++ b/third_party/WebKit/Source/platform/text/CompressibleString.cpp

@@ -4,7 +4,7 @@

#include "platform/text/CompressibleString.h"

-#include "public/platform/Platform.h"

+#include "platform/Histogram.h"

#include "wtf/Assertions.h"

#include "wtf/WTFThreadData.h"

#include "wtf/text/WTFString.h"

@@ -97,7 +97,8 @@ enum CompressibleStringCountType {

static void recordCompressibleStringCount(CompressibleStringCountType type)

{

- Platform::current()->histogramEnumeration("Memory.CompressibleStringCount", type, CompressibleStringCountTypeMax + 1);

+ DEFINE_THREAD_SAFE_STATIC_LOCAL(EnumerationHistogram, sringTypeHistogram, new EnumerationHistogram("Memory.CompressibleStringCount", CompressibleStringCountTypeMax + 1));

+ sringTypeHistogram.count(type);

}

// compressString does nothing but collect UMA so far.