Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1652873003: Pdfium does not create isolate when it runs in chromium (Closed)

Created:
4 years, 10 months ago by Jim Wang
Modified:
4 years, 10 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M fpdfsdk/include/fpdfxfa/fpdfxfa_app.h View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/include/fxjse/fxjse.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxjse/src/runtime.cpp View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Jim Wang
@jun, please help to start review this.
4 years, 10 months ago (2016-02-01 10:08:34 UTC) #2
jun_fang
https://codereview.chromium.org/1652873003/diff/1/fpdfsdk/src/fpdfview.cpp File fpdfsdk/src/fpdfview.cpp (right): https://codereview.chromium.org/1652873003/diff/1/fpdfsdk/src/fpdfview.cpp#newcode245 fpdfsdk/src/fpdfview.cpp:245: (cfg && cfg->version >= 2) ? (FXJSE_HRUNTIME)cfg->m_pIsolate : nullptr); ...
4 years, 10 months ago (2016-02-01 11:01:19 UTC) #4
Jim Wang
Hi Lei and jochen, please help to start review this.
4 years, 10 months ago (2016-02-01 11:06:42 UTC) #6
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1652873003/diff/1/xfa/src/fxjse/src/runtime.cpp File xfa/src/fxjse/src/runtime.cpp (right): https://codereview.chromium.org/1652873003/diff/1/xfa/src/fxjse/src/runtime.cpp#newcode70 xfa/src/fxjse/src/runtime.cpp:70: v8::Locker locker(pIsolate); don't use v8::Locker
4 years, 10 months ago (2016-02-01 12:06:37 UTC) #7
Jim Wang
https://codereview.chromium.org/1652873003/diff/1/fpdfsdk/src/fpdfview.cpp File fpdfsdk/src/fpdfview.cpp (right): https://codereview.chromium.org/1652873003/diff/1/fpdfsdk/src/fpdfview.cpp#newcode245 fpdfsdk/src/fpdfview.cpp:245: (cfg && cfg->version >= 2) ? (FXJSE_HRUNTIME)cfg->m_pIsolate : nullptr); ...
4 years, 10 months ago (2016-02-02 03:43:18 UTC) #8
Jim Wang
https://codereview.chromium.org/1652873003/diff/1/xfa/src/fxjse/src/runtime.cpp File xfa/src/fxjse/src/runtime.cpp (right): https://codereview.chromium.org/1652873003/diff/1/xfa/src/fxjse/src/runtime.cpp#newcode70 xfa/src/fxjse/src/runtime.cpp:70: v8::Locker locker(pIsolate); On 2016/02/01 12:06:37, jochen wrote: > don't ...
4 years, 10 months ago (2016-02-02 03:46:36 UTC) #9
jun_fang
On 2016/02/02 03:46:36, Jim Wang wrote: > https://codereview.chromium.org/1652873003/diff/1/xfa/src/fxjse/src/runtime.cpp > File xfa/src/fxjse/src/runtime.cpp (right): > > https://codereview.chromium.org/1652873003/diff/1/xfa/src/fxjse/src/runtime.cpp#newcode70 ...
4 years, 10 months ago (2016-02-02 23:20:45 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-03 13:32:48 UTC) #11
Jim Wang
4 years, 10 months ago (2016-02-04 01:42:10 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
486615821300724aef55035f4f831f548fb9cab6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698