fpdfsdk/src/javascript/JS_Runtime.cpp - Issue 1652873003: Pdfium does not create isolate when it runs in chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.cpp

Issue 1652873003: Pdfium does not create isolate when it runs in chromium (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Runtime.cpp

diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp

index ba6d748ade90fe83c23056d1950b8f0f112e92fe..95f392487a070e422d49f57ff1e6bc1a86ae6b12 100644

--- a/fpdfsdk/src/javascript/JS_Runtime.cpp

+++ b/fpdfsdk/src/javascript/JS_Runtime.cpp

@@ -121,9 +121,7 @@ CJS_Runtime::~CJS_Runtime() {

delete m_ContextArray.GetAt(i);

m_ContextArray.RemoveAll();

-#ifndef PDF_ENABLE_XFA

FXJS_ReleaseRuntime(GetIsolate(), &m_context, &m_StaticObjects);

-#endif

m_pApp = NULL;

m_pDocument = NULL;

« no previous file with comments | « fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp ('k') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('j') | no next file with comments »