xfa/include/fxjse/fxjse.h - Issue 1652873003: Pdfium does not create isolate when it runs in chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/include/fxjse/fxjse.h

Issue 1652873003: Pdfium does not create isolate when it runs in chromium (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/include/fxjse/fxjse.h

diff --git a/xfa/include/fxjse/fxjse.h b/xfa/include/fxjse/fxjse.h

index bac63208f82a1e9894965458b1112782af949958..b8a2af4b8a723886367f92b8a3047d40265d4710 100644

--- a/xfa/include/fxjse/fxjse.h

+++ b/xfa/include/fxjse/fxjse.h

@@ -24,7 +24,7 @@ typedef double FXJSE_DOUBLE;

void FXJSE_Initialize();

void FXJSE_Finalize();

FXJSE_HRUNTIME FXJSE_Runtime_Create();

-void FXJSE_Runtime_Release(FXJSE_HRUNTIME hRuntime);

+void FXJSE_Runtime_Release(FXJSE_HRUNTIME hRuntime, bool bOwnedRuntime);

typedef struct _FXJSE_CLASS FXJSE_CLASS;

FXJSE_HCONTEXT FXJSE_Context_Create(FXJSE_HRUNTIME hRuntime,

const FXJSE_CLASS* lpGlobalClass = nullptr,

« no previous file with comments | « fpdfsdk/src/jsapi/fxjs_v8.cpp ('k') | xfa/src/fxjse/src/runtime.cpp » ('j') | no next file with comments »