Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 1651913005: [runtime] Fix integer indexed property handling (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Fix integer indexed property handling This includes 2 fixes: 1) We didn't properly advance the holder when checking whether Receiver==Holder, so we'd inadvertently block loading the property if the first property we find is on the typed array. 2) Reflect.get may cause any object on the prototype chain of the holder to be the receiver; so we need to recheck for this special state for each object we perform lookup on. Committed: https://crrev.com/621bdd642cc60f0ff1bd1fbececce7a891bd0fbc Cr-Commit-Position: refs/heads/master@{#33689}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -43 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.h View 1 7 chunks +0 lines, -7 lines 0 comments Download
M src/lookup.cc View 1 3 chunks +14 lines, -31 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-integer-indexed-element.js View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-02 15:21:16 UTC) #4
Jakob Kummerow
LGTM https://codereview.chromium.org/1651913005/diff/40001/test/mjsunit/regress/regress-integer-indexed-element.js File test/mjsunit/regress/regress-integer-indexed-element.js (right): https://codereview.chromium.org/1651913005/diff/40001/test/mjsunit/regress/regress-integer-indexed-element.js#newcode1 test/mjsunit/regress/regress-integer-indexed-element.js:1: // Copyright 2015 the V8 project authors. All ...
4 years, 10 months ago (2016-02-02 15:31:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651913005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651913005/80001
4 years, 10 months ago (2016-02-02 16:36:49 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 10 months ago (2016-02-02 17:02:02 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 17:02:30 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/621bdd642cc60f0ff1bd1fbececce7a891bd0fbc
Cr-Commit-Position: refs/heads/master@{#33689}

Powered by Google App Engine
This is Rietveld 408576698