Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: src/lookup.h

Issue 1651913005: [runtime] Fix integer indexed property handling (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/lookup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index 6fe68dc65ec84a9f4a8b75e1e1316e0ccd275a78..4d55e62d81ce1ecab67cc80d193c2c7d4d377201 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -48,7 +48,6 @@ class LookupIterator final BASE_EMBEDDED {
Configuration configuration = DEFAULT)
: configuration_(ComputeConfiguration(configuration, name)),
state_(NOT_FOUND),
- exotic_index_state_(ExoticIndexState::kUninitialized),
interceptor_state_(InterceptorState::kUninitialized),
property_details_(PropertyDetails::Empty()),
isolate_(name->GetIsolate()),
@@ -72,7 +71,6 @@ class LookupIterator final BASE_EMBEDDED {
Configuration configuration = DEFAULT)
: configuration_(ComputeConfiguration(configuration, name)),
state_(NOT_FOUND),
- exotic_index_state_(ExoticIndexState::kUninitialized),
interceptor_state_(InterceptorState::kUninitialized),
property_details_(PropertyDetails::Empty()),
isolate_(name->GetIsolate()),
@@ -95,7 +93,6 @@ class LookupIterator final BASE_EMBEDDED {
Configuration configuration = DEFAULT)
: configuration_(configuration),
state_(NOT_FOUND),
- exotic_index_state_(ExoticIndexState::kUninitialized),
interceptor_state_(InterceptorState::kUninitialized),
property_details_(PropertyDetails::Empty()),
isolate_(isolate),
@@ -116,7 +113,6 @@ class LookupIterator final BASE_EMBEDDED {
Configuration configuration = DEFAULT)
: configuration_(configuration),
state_(NOT_FOUND),
- exotic_index_state_(ExoticIndexState::kUninitialized),
interceptor_state_(InterceptorState::kUninitialized),
property_details_(PropertyDetails::Empty()),
isolate_(isolate),
@@ -280,7 +276,6 @@ class LookupIterator final BASE_EMBEDDED {
void ReloadPropertyInformation();
inline bool SkipInterceptor(JSObject* holder);
bool HasInterceptor(Map* map) const;
- bool InternalHolderIsReceiverOrHiddenPrototype() const;
inline InterceptorInfo* GetInterceptor(JSObject* holder) const {
if (IsElement()) return holder->GetIndexedInterceptor();
return holder->GetNamedInterceptor();
@@ -320,7 +315,6 @@ class LookupIterator final BASE_EMBEDDED {
return GetRootForNonJSReceiver(isolate, receiver, index);
}
- enum class ExoticIndexState { kUninitialized, kNotExotic, kExotic };
inline bool IsIntegerIndexedExotic(JSReceiver* holder);
// If configuration_ becomes mutable, update
@@ -328,7 +322,6 @@ class LookupIterator final BASE_EMBEDDED {
const Configuration configuration_;
State state_;
bool has_property_;
- ExoticIndexState exotic_index_state_;
InterceptorState interceptor_state_;
PropertyDetails property_details_;
Isolate* const isolate_;
« no previous file with comments | « src/builtins.cc ('k') | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698