Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: src/objects-inl.h

Issue 1651913005: [runtime] Fix integer indexed property handling (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | test/mjsunit/regress/regress-integer-indexed-element.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 7066 matching lines...) Expand 10 before | Expand all | Expand 10 after
7077 7077
7078 7078
7079 MaybeHandle<Object> Object::GetPropertyOrElement(Handle<Object> object, 7079 MaybeHandle<Object> Object::GetPropertyOrElement(Handle<Object> object,
7080 Handle<Name> name, 7080 Handle<Name> name,
7081 LanguageMode language_mode) { 7081 LanguageMode language_mode) {
7082 LookupIterator it = 7082 LookupIterator it =
7083 LookupIterator::PropertyOrElement(name->GetIsolate(), object, name); 7083 LookupIterator::PropertyOrElement(name->GetIsolate(), object, name);
7084 return GetProperty(&it, language_mode); 7084 return GetProperty(&it, language_mode);
7085 } 7085 }
7086 7086
7087 7087 MaybeHandle<Object> Object::GetPropertyOrElement(Handle<Object> receiver,
7088 MaybeHandle<Object> Object::GetPropertyOrElement(Handle<JSReceiver> holder,
7089 Handle<Name> name, 7088 Handle<Name> name,
7090 Handle<Object> receiver, 7089 Handle<JSReceiver> holder,
7091 LanguageMode language_mode) { 7090 LanguageMode language_mode) {
7092 LookupIterator it = LookupIterator::PropertyOrElement( 7091 LookupIterator it = LookupIterator::PropertyOrElement(
7093 name->GetIsolate(), receiver, name, holder); 7092 name->GetIsolate(), receiver, name, holder);
7094 return GetProperty(&it, language_mode); 7093 return GetProperty(&it, language_mode);
7095 } 7094 }
7096 7095
7097 7096
7098 void JSReceiver::initialize_properties() { 7097 void JSReceiver::initialize_properties() {
7099 DCHECK(!GetHeap()->InNewSpace(GetHeap()->empty_fixed_array())); 7098 DCHECK(!GetHeap()->InNewSpace(GetHeap()->empty_fixed_array()));
7100 DCHECK(!GetHeap()->InNewSpace(GetHeap()->empty_properties_dictionary())); 7099 DCHECK(!GetHeap()->InNewSpace(GetHeap()->empty_properties_dictionary()));
(...skipping 739 matching lines...) Expand 10 before | Expand all | Expand 10 after
7840 #undef WRITE_INT64_FIELD 7839 #undef WRITE_INT64_FIELD
7841 #undef READ_BYTE_FIELD 7840 #undef READ_BYTE_FIELD
7842 #undef WRITE_BYTE_FIELD 7841 #undef WRITE_BYTE_FIELD
7843 #undef NOBARRIER_READ_BYTE_FIELD 7842 #undef NOBARRIER_READ_BYTE_FIELD
7844 #undef NOBARRIER_WRITE_BYTE_FIELD 7843 #undef NOBARRIER_WRITE_BYTE_FIELD
7845 7844
7846 } // namespace internal 7845 } // namespace internal
7847 } // namespace v8 7846 } // namespace v8
7848 7847
7849 #endif // V8_OBJECTS_INL_H_ 7848 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | test/mjsunit/regress/regress-integer-indexed-element.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698