third_party/WebKit/Source/core/layout/line/EllipsisBox.h - Issue 1651703002: More explicit LayoutUnit conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/EllipsisBox.h

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors

Patch Set: Traits vs Properties vs Pandas Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/EllipsisBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/EllipsisBox.h b/third_party/WebKit/Source/core/layout/line/EllipsisBox.h

index 43d74bfdf06e66f5819b714d999a7ca0a8fbfa4f..33f5af01dee7be4c7f03e3b9a99454cb1c42abb7 100644

--- a/third_party/WebKit/Source/core/layout/line/EllipsisBox.h

+++ b/third_party/WebKit/Source/core/layout/line/EllipsisBox.h

@@ -45,7 +45,7 @@ public:

void setSelectionState(SelectionState s) { m_selectionState = s; }

IntRect selectionRect() const;

- LayoutUnit virtualLogicalHeight() const override { return m_height; }

+ LayoutUnit virtualLogicalHeight() const override { return LayoutUnit(m_height); }

SelectionState selectionState() const override { return m_selectionState; }

const AtomicString& ellipsisStr() const { return m_str; }