third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp - Issue 1651703002: More explicit LayoutUnit conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors

Patch Set: Traits vs Properties vs Pandas Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp b/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

index 9cf1038f4d9f51404dae61d7b0b12da10d07589f..238d82d44373be06752d70f6f059cd5b64daab71 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

@@ -215,8 +215,8 @@ void LayoutTreeAsText::writeLayoutObject(TextStream& ts, const LayoutObject& o,

r.move(0, -toLayoutTableCell(o.containingBlock())->intrinsicPaddingBefore());

if (o.isLayoutView()) {

- r.setWidth(toLayoutView(o).viewWidth(IncludeScrollbars));

- r.setHeight(toLayoutView(o).viewHeight(IncludeScrollbars));

+ r.setWidth(LayoutUnit(toLayoutView(o).viewWidth(IncludeScrollbars)));

+ r.setHeight(LayoutUnit(toLayoutView(o).viewHeight(IncludeScrollbars)));

}

ts << " " << r;