third_party/WebKit/Source/core/layout/line/LineWidth.cpp - Issue 1651703002: More explicit LayoutUnit conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/LineWidth.cpp

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors

Patch Set: Traits vs Properties vs Pandas Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/LineWidth.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/LineWidth.cpp b/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

index ce4060125bf81efc2ac5bf92cfc958ee85566ce5..83c77b97e9a75501bec538773da6fc4593e43678 100644

--- a/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

+++ b/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

@@ -119,7 +119,7 @@ void LineWidth::applyOverhang(LineLayoutRubyRun rubyRun, LineLayoutItem startLay

}

inline static float availableWidthAtOffset(LineLayoutBlockFlow block, const LayoutUnit& offset, IndentTextOrNot indentText, float& newLineLeft,

- float& newLineRight, const LayoutUnit& lineHeight = 0)

+ float& newLineRight, const LayoutUnit& lineHeight = LayoutUnit())

{

newLineLeft = block.logicalLeftOffsetForLine(offset, indentText, lineHeight).toFloat();

newLineRight = block.logicalRightOffsetForLine(offset, indentText, lineHeight).toFloat();