third_party/WebKit/Source/core/layout/LayoutTextControl.cpp - Issue 1651703002: More explicit LayoutUnit conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors

Patch Set: Traits vs Properties vs Pandas Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp b/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

index decfe8c978bfd09b614088d0c611e6a6fa3575c9..2ea7fdd791a91b9d5012a6c0114b86f9ab797807 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

@@ -242,8 +242,8 @@ void LayoutTextControl::computePreferredLogicalWidths()

{

ASSERT(preferredLogicalWidthsDirty());

- m_minPreferredLogicalWidth = 0;

- m_maxPreferredLogicalWidth = 0;

+ m_minPreferredLogicalWidth = LayoutUnit();

+ m_maxPreferredLogicalWidth = LayoutUnit();

const ComputedStyle& styleToUse = styleRef();

if (styleToUse.logicalWidth().isFixed() && styleToUse.logicalWidth().value() >= 0)