Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1651183003: Make PlatformChannelPair "dumb". (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make PlatformChannelPair "dumb". Now it's just a helper that creates two "connected" PlatformHandles (modelled after mojo::MessagePipe, mojo::DataPipe, etc.). Passing one handle to the child is now done manually. (I want to move it to //mojo/edk/platform and maybe rename it too, but I'll do that separately.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2ae2bccb82f37947c69ab5d6e06c2d109690a394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -216 lines) Patch
M mojo/edk/embedder/multiprocess_embedder_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair.h View 2 chunks +6 lines, -57 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair.cc View 2 chunks +5 lines, -76 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/channel_manager_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/channel_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/connection_manager_unittest.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 4 chunks +13 lines, -19 lines 0 comments Download
M shell/child_main.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M shell/child_process_host.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M shell/child_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M shell/child_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 10 months ago (2016-02-01 19:36:27 UTC) #1
vardhan
lgtm
4 years, 10 months ago (2016-02-01 22:37:25 UTC) #2
viettrungluu
4 years, 10 months ago (2016-02-01 22:50:09 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2ae2bccb82f37947c69ab5d6e06c2d109690a394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698