Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: mojo/edk/embedder/platform_channel_pair_unittest.cc

Issue 1651183003: Make PlatformChannelPair "dumb". (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/embedder/platform_channel_pair.cc ('k') | mojo/edk/system/channel_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/embedder/platform_channel_pair_unittest.cc
diff --git a/mojo/edk/embedder/platform_channel_pair_unittest.cc b/mojo/edk/embedder/platform_channel_pair_unittest.cc
index 15250aa6d6b8b9262b6044b3ea74ec67e3c743d9..46c849f0b342d20ea0316f7c5835f8d63ca03964 100644
--- a/mojo/edk/embedder/platform_channel_pair_unittest.cc
+++ b/mojo/edk/embedder/platform_channel_pair_unittest.cc
@@ -67,8 +67,8 @@ class PlatformChannelPairTest : public testing::Test {
TEST_F(PlatformChannelPairTest, NoSigPipe) {
PlatformChannelPair channel_pair;
- ScopedPlatformHandle server_handle = channel_pair.PassServerHandle();
- ScopedPlatformHandle client_handle = channel_pair.PassClientHandle();
+ ScopedPlatformHandle server_handle = channel_pair.handle0.Pass();
+ ScopedPlatformHandle client_handle = channel_pair.handle1.Pass();
// Write to the client.
static const char kHello[] = "hello";
@@ -108,8 +108,8 @@ TEST_F(PlatformChannelPairTest, NoSigPipe) {
TEST_F(PlatformChannelPairTest, SendReceiveData) {
PlatformChannelPair channel_pair;
- ScopedPlatformHandle server_handle = channel_pair.PassServerHandle();
- ScopedPlatformHandle client_handle = channel_pair.PassClientHandle();
+ ScopedPlatformHandle server_handle = channel_pair.handle0.Pass();
+ ScopedPlatformHandle client_handle = channel_pair.handle1.Pass();
for (size_t i = 0; i < 10; i++) {
std::string send_string(1 << i, 'A' + i);
@@ -136,8 +136,8 @@ TEST_F(PlatformChannelPairTest, SendReceiveFDs) {
static const char kHello[] = "hello";
PlatformChannelPair channel_pair;
- ScopedPlatformHandle server_handle = channel_pair.PassServerHandle();
- ScopedPlatformHandle client_handle = channel_pair.PassClientHandle();
+ ScopedPlatformHandle server_handle = channel_pair.handle0.Pass();
+ ScopedPlatformHandle client_handle = channel_pair.handle1.Pass();
// Reduce the number of FDs opened on OS X to avoid test flake.
#if defined(OS_MACOSX)
@@ -199,8 +199,8 @@ TEST_F(PlatformChannelPairTest, AppendReceivedFDs) {
static const char kHello[] = "hello";
PlatformChannelPair channel_pair;
- ScopedPlatformHandle server_handle = channel_pair.PassServerHandle();
- ScopedPlatformHandle client_handle = channel_pair.PassClientHandle();
+ ScopedPlatformHandle server_handle = channel_pair.handle0.Pass();
+ ScopedPlatformHandle client_handle = channel_pair.handle1.Pass();
const std::string file_contents("hello world");
« no previous file with comments | « mojo/edk/embedder/platform_channel_pair.cc ('k') | mojo/edk/system/channel_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698