Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: mojo/edk/embedder/multiprocess_embedder_unittest.cc

Issue 1651183003: Make PlatformChannelPair "dumb". (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/edk/embedder/platform_channel_pair.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/embedder/multiprocess_embedder_unittest.cc
diff --git a/mojo/edk/embedder/multiprocess_embedder_unittest.cc b/mojo/edk/embedder/multiprocess_embedder_unittest.cc
index e848df14a216f4898bc34f2df38854f11490c1e2..ae26a424a27c14c47da9565d3693764710b3ecf5 100644
--- a/mojo/edk/embedder/multiprocess_embedder_unittest.cc
+++ b/mojo/edk/embedder/multiprocess_embedder_unittest.cc
@@ -148,10 +148,10 @@ TEST_F(MultiprocessEmbedderTest, ChannelsBasic) {
test_io_watcher());
PlatformChannelPair channel_pair;
- ScopedTestChannel server_channel(channel_pair.PassServerHandle());
+ ScopedTestChannel server_channel(channel_pair.handle0.Pass());
MojoHandle server_mp = server_channel.bootstrap_message_pipe();
EXPECT_NE(server_mp, MOJO_HANDLE_INVALID);
- ScopedTestChannel client_channel(channel_pair.PassClientHandle());
+ ScopedTestChannel client_channel(channel_pair.handle1.Pass());
MojoHandle client_mp = client_channel.bootstrap_message_pipe();
EXPECT_NE(client_mp, MOJO_HANDLE_INVALID);
@@ -194,10 +194,10 @@ TEST_F(MultiprocessEmbedderTest, ChannelsHandlePassing) {
test_io_watcher());
PlatformChannelPair channel_pair;
- ScopedTestChannel server_channel(channel_pair.PassServerHandle());
+ ScopedTestChannel server_channel(channel_pair.handle0.Pass());
MojoHandle server_mp = server_channel.bootstrap_message_pipe();
EXPECT_NE(server_mp, MOJO_HANDLE_INVALID);
- ScopedTestChannel client_channel(channel_pair.PassClientHandle());
+ ScopedTestChannel client_channel(channel_pair.handle1.Pass());
MojoHandle client_mp = client_channel.bootstrap_message_pipe();
EXPECT_NE(client_mp, MOJO_HANDLE_INVALID);
@@ -370,7 +370,7 @@ TEST_F(MultiprocessEmbedderTest, ChannelShutdownRace_MessagePipeClose) {
for (size_t i = 0; i < kIterations; i++) {
PlatformChannelPair channel_pair;
std::unique_ptr<ScopedTestChannel> server_channel(
- new ScopedTestChannel(channel_pair.PassServerHandle()));
+ new ScopedTestChannel(channel_pair.handle0.Pass()));
server_channel->WaitForChannelCreationCompletion();
server_channel->NoWaitOnShutdown();
« no previous file with comments | « no previous file | mojo/edk/embedder/platform_channel_pair.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698