Revert of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with scoped_ptr.

Revert of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with scoped_ptr. (patchset #5 id:80001 of https://codereview.chromium.org/1629703002/ )

Reason for revert:
Breaks ninja build on Linux GN.

Original issue's description:
> [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with scoped_ptr.
>
> Previously naked pointers AssemblyProgram and EncodedProgram are used over the
> place, and are deallocated using Delete{AssemblyProgram, EncodedProgram}().
> In this CL we use scoped_ptr to manage the life cycles of these objects.
>
> - Removed DeleteAssemblyProgram() and DeleteEncodedProgram() and replaced calls
>   with e.g., program.reset(nullptr); if the manual deallocation is a peak
>   memory optimization.
> - Moved Encode() and ReadEncodedProgram() to the .h files matching the .cc files.
> - Extracted DetectExecutableType() and ParseDetectedExecutable() from
>   disassembly.* to new files program_detector*c, since Disassembly is really an
>   implementation that caller's don't care about.
>
> Committed: https://crrev.com/0a9cbf1781a114b35a4e0f4a834f2d24ade2e917
> Cr-Commit-Position: refs/heads/master@{#372212}

TBR=wfh@chromium.org,grt@chromium.org,huangs@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/7958406fb94ffb798859006fef04dbd0d4164079
Cr-Commit-Position: refs/heads/master@{#372274}

[dcheng, 2016-01-29 03:13:03]

Created Revert of [Courgette] Refactor: Manage AssemblyProgram and
EncodedProgram with scoped_ptr.

[commit-bot: I haz the power, 2016-01-29 03:13:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650013002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650013002/1

[commit-bot: I haz the power, 2016-01-29 03:14:34]

Committed patchset #1 (id:1)

[Will Harris, 2016-01-29 03:15:14]

On 2016/01/29 03:14:34, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1)

lgtm thanks for revert. Hopefully easy to fix.

[commit-bot: I haz the power, 2016-01-29 03:15:43]

Description was changed from

==========
Revert of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr. (patchset #5 id:80001 of https://codereview.chromium.org/1629703002/
)

Reason for revert:
Breaks ninja build on Linux GN.

Original issue's description:
> [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr.
> 
> Previously naked pointers AssemblyProgram and EncodedProgram are used over the
> place, and are deallocated using Delete{AssemblyProgram, EncodedProgram}().
> In this CL we use scoped_ptr to manage the life cycles of these objects.
> 
> - Removed DeleteAssemblyProgram() and DeleteEncodedProgram() and replaced
calls
>   with e.g., program.reset(nullptr); if the manual deallocation is a peak
>   memory optimization.
> - Moved Encode() and ReadEncodedProgram() to the .h files matching the .cc
files.
> - Extracted DetectExecutableType() and ParseDetectedExecutable() from
>   disassembly.* to new files program_detector*c, since Disassembly is really
an
>   implementation that caller's don't care about.
> 
> Committed: https://crrev.com/0a9cbf1781a114b35a4e0f4a834f2d24ade2e917
> Cr-Commit-Position: refs/heads/master@{#372212}

TBR=wfh@chromium.org,grt@chromium.org,huangs@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr. (patchset #5 id:80001 of https://codereview.chromium.org/1629703002/
)

Reason for revert:
Breaks ninja build on Linux GN.

Original issue's description:
> [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr.
>
> Previously naked pointers AssemblyProgram and EncodedProgram are used over the
> place, and are deallocated using Delete{AssemblyProgram, EncodedProgram}().
> In this CL we use scoped_ptr to manage the life cycles of these objects.
>
> - Removed DeleteAssemblyProgram() and DeleteEncodedProgram() and replaced
calls
>   with e.g., program.reset(nullptr); if the manual deallocation is a peak
>   memory optimization.
> - Moved Encode() and ReadEncodedProgram() to the .h files matching the .cc
files.
> - Extracted DetectExecutableType() and ParseDetectedExecutable() from
>   disassembly.* to new files program_detector*c, since Disassembly is really
an
>   implementation that caller's don't care about.
>
> Committed: https://crrev.com/0a9cbf1781a114b35a4e0f4a834f2d24ade2e917
> Cr-Commit-Position: refs/heads/master@{#372212}

TBR=wfh@chromium.org,grt@chromium.org,huangs@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/7958406fb94ffb798859006fef04dbd0d4164079
Cr-Commit-Position: refs/heads/master@{#372274}
==========

[commit-bot: I haz the power, 2016-01-29 03:15:45]

Patchset 1 (id:??) landed as
https://crrev.com/7958406fb94ffb798859006fef04dbd0d4164079
Cr-Commit-Position: refs/heads/master@{#372274}

[huangs, 2016-01-29 15:02:14]

Sorry for the trouble, and thanks for taking care of this!

[huangs, 2016-01-29 15:44:23]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1648313002/ by huangs@chromium.org.

The reason for reverting is: Relanding patch set with fix..