[ABANDONED] Reland Issue 1629703002

Reland of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with scoped_ptr. (patchset #1 id:1 of https://codereview.chromium.org/1650013002/ )

Reason for revert:
Relanding patch set with fix.

Original issue's description:
> Revert of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with scoped_ptr. (patchset #5 id:80001 of https://codereview.chromium.org/1629703002/ )
> 
> Reason for revert:
> Breaks ninja build on Linux GN.
> 
> Original issue's description:
> > [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with scoped_ptr.
> >
> > Previously naked pointers AssemblyProgram and EncodedProgram are used over the
> > place, and are deallocated using Delete{AssemblyProgram, EncodedProgram}().
> > In this CL we use scoped_ptr to manage the life cycles of these objects.
> >
> > - Removed DeleteAssemblyProgram() and DeleteEncodedProgram() and replaced calls
> >   with e.g., program.reset(nullptr); if the manual deallocation is a peak
> >   memory optimization.
> > - Moved Encode() and ReadEncodedProgram() to the .h files matching the .cc files.
> > - Extracted DetectExecutableType() and ParseDetectedExecutable() from
> >   disassembly.* to new files program_detector*c, since Disassembly is really an
> >   implementation that caller's don't care about.
> >
> > Committed: https://crrev.com/0a9cbf1781a114b35a4e0f4a834f2d24ade2e917
> > Cr-Commit-Position: refs/heads/master@{#372212}
> 
> TBR=wfh@chromium.org,grt@chromium.org,huangs@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Committed: https://crrev.com/7958406fb94ffb798859006fef04dbd0d4164079
> Cr-Commit-Position: refs/heads/master@{#372274}

TBR=wfh@chromium.org,grt@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

[huangs, 2016-01-29 15:44:23]

Created Reland of [Courgette] Refactor: Manage AssemblyProgram and
EncodedProgram with scoped_ptr.

[huangs, 2016-01-29 16:51:32]

Getting weird patch failures on try bots:

Failed to apply patch for courgette/BUILD.gn:
While running git apply --index -3 -p1 --verbose;
  Created missing directory courgette.
  Checking patch courgette/BUILD.gn...
  error: courgette/BUILD.gn: does not exist in index

Going to create a new CL to do the relanding.

[Will Harris, 2016-01-29 17:58:53]

On 2016/01/29 16:51:32, huangs wrote:
> Getting weird patch failures on try bots:
> 
> Failed to apply patch for courgette/BUILD.gn:
> While running git apply --index -3 -p1 --verbose;
>   Created missing directory courgette.
>   Checking patch courgette/BUILD.gn...
>   error: courgette/BUILD.gn: does not exist in index
> 
> Going to create a new CL to do the relanding.

yup normally you don't revert the revert (which I think you might have done)
instead you just either do your fix in the original CL as a new PS, or create a
new CL from the latest PS of the reverted CL and then submit that CL (either is
fine, it depends on reviewer and size of the fix you have to make)

[huangs, 2016-01-29 18:00:38]

Ah okay.  I figured if they bothered to have code insert "Reland" then this is a
normal flow.  Anyway I just made a new CL
https://codereview.chromium.org/1648393002 , hopefully patching will work.

[huangs, 2016-01-29 18:59:07]

Looks like the failure was on weird bots that fail to patch.  I'm going to:
- Delete https://codereview.chromium.org/1648393002 
- Keep this CL around as abandoned.
- Fix the the original CL.

[grt (UTC plus 2), 2016-01-29 21:10:37]

On 2016/01/29 18:59:07, huangs wrote:
> Looks like the failure was on weird bots that fail to patch.  I'm going to:
> - Delete https://codereview.chromium.org/1648393002 
> - Keep this CL around as abandoned.
> - Fix the the original CL.

Please check the "Closed" box on this CR's edit page so that it's clear to
reviewers that it's been abandoned. Thanks!

[huangs, 2016-01-29 21:12:27]

Description was changed from

==========
Reland of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr. (patchset #1 id:1 of https://codereview.chromium.org/1650013002/ )

Reason for revert:
Relanding patch set with fix.

Original issue's description:
> Revert of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr. (patchset #5 id:80001 of https://codereview.chromium.org/1629703002/
)
> 
> Reason for revert:
> Breaks ninja build on Linux GN.
> 
> Original issue's description:
> > [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr.
> >
> > Previously naked pointers AssemblyProgram and EncodedProgram are used over
the
> > place, and are deallocated using Delete{AssemblyProgram, EncodedProgram}().
> > In this CL we use scoped_ptr to manage the life cycles of these objects.
> >
> > - Removed DeleteAssemblyProgram() and DeleteEncodedProgram() and replaced
calls
> >   with e.g., program.reset(nullptr); if the manual deallocation is a peak
> >   memory optimization.
> > - Moved Encode() and ReadEncodedProgram() to the .h files matching the .cc
files.
> > - Extracted DetectExecutableType() and ParseDetectedExecutable() from
> >   disassembly.* to new files program_detector*c, since Disassembly is really
an
> >   implementation that caller's don't care about.
> >
> > Committed: https://crrev.com/0a9cbf1781a114b35a4e0f4a834f2d24ade2e917
> > Cr-Commit-Position: refs/heads/master@{#372212}
> 
> TBR=wfh@chromium.org,grt@chromium.org,huangs@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Committed: https://crrev.com/7958406fb94ffb798859006fef04dbd0d4164079
> Cr-Commit-Position: refs/heads/master@{#372274}

TBR=wfh@chromium.org,grt@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Reland of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr. (patchset #1 id:1 of https://codereview.chromium.org/1650013002/ )

Reason for revert:
Relanding patch set with fix.

Original issue's description:
> Revert of [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr. (patchset #5 id:80001 of https://codereview.chromium.org/1629703002/
)
> 
> Reason for revert:
> Breaks ninja build on Linux GN.
> 
> Original issue's description:
> > [Courgette] Refactor: Manage AssemblyProgram and EncodedProgram with
scoped_ptr.
> >
> > Previously naked pointers AssemblyProgram and EncodedProgram are used over
the
> > place, and are deallocated using Delete{AssemblyProgram, EncodedProgram}().
> > In this CL we use scoped_ptr to manage the life cycles of these objects.
> >
> > - Removed DeleteAssemblyProgram() and DeleteEncodedProgram() and replaced
calls
> >   with e.g., program.reset(nullptr); if the manual deallocation is a peak
> >   memory optimization.
> > - Moved Encode() and ReadEncodedProgram() to the .h files matching the .cc
files.
> > - Extracted DetectExecutableType() and ParseDetectedExecutable() from
> >   disassembly.* to new files program_detector*c, since Disassembly is really
an
> >   implementation that caller's don't care about.
> >
> > Committed: https://crrev.com/0a9cbf1781a114b35a4e0f4a834f2d24ade2e917
> > Cr-Commit-Position: refs/heads/master@{#372212}
> 
> TBR=wfh@chromium.org,grt@chromium.org,huangs@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Committed: https://crrev.com/7958406fb94ffb798859006fef04dbd0d4164079
> Cr-Commit-Position: refs/heads/master@{#372274}

TBR=wfh@chromium.org,grt@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========