Issue 16490003: Pass the SiteInstance into CreateRenderProcessHost

Issue 16490003: Pass the SiteInstance into CreateRenderProcessHost (Closed)

Created:
7 years, 6 months ago by Jeffrey Yasskin

Modified:
7 years, 6 months ago

Reviewers:
Charlie Reis, gbillock, sky

CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sail+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pass the SiteInstance into CreateRenderProcessHost so that the RenderProcessHostFactory has as much information as the default branch. TBR=gbillock Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204613

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove ContentBrowserClient, which is global, from argument list #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
M	chrome/browser/media_galleries/media_file_system_registry_unittest.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	components/visitedlink/test/visitedlink_unittest.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/text_input_client_mac_unittest.mm	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/site_instance_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/render_process_host_factory.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/public/test/mock_render_process_host.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/public/test/mock_render_process_host.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Jeffrey Yasskin

This CL implements the comments at https://codereview.chromium.org/16267002/diff/16001/content/browser/renderer_host/render_process_host_impl_unittest.cc#newcode182. It depends on https://codereview.chromium.org/15799009/. creis and/or jam for ...

7 years, 6 months ago (2013-06-05 22:28:46 UTC) #1

Charlie Reis

https://codereview.chromium.org/16490003/diff/1/content/public/browser/render_process_host_factory.h File content/public/browser/render_process_host_factory.h (right): https://codereview.chromium.org/16490003/diff/1/content/public/browser/render_process_host_factory.h#newcode25 content/public/browser/render_process_host_factory.h:25: ContentBrowserClient* client) const = 0; Hmm, isn't the ContentBrowserClient ...

7 years, 6 months ago (2013-06-05 22:37:30 UTC) #2

Jeffrey Yasskin

7 years, 6 months ago (2013-06-05 23:01:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/16490003/4001

7 years, 6 months ago (2013-06-06 19:06:02 UTC) #6

Message was sent while issue was closed.

Change committed as 204613

Expand Messages | Collapse Messages