Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 15799009: Store the RenderProcessHostFactory in a global variable (Closed)

Created:
7 years, 6 months ago by Jeffrey Yasskin
Modified:
7 years, 6 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, creis+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Store the RenderProcessHostFactory in a global variable instead of a member variable within each SiteInstance. The local variable in one SiteInstance was documented to be passed on to other SiteInstances spawned from it, but that never actually worked. Even fixing that doesn't serve the use case of allowing different RenderProcessHostFactories for different trees of SiteInstances because of the many calls to SiteInstance::CreateForURL inside RenderViewHostManager. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -41 lines) Patch
M content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/site_instance_impl.h View 2 chunks +9 lines, -8 lines 0 comments Download
M content/browser/site_instance_impl.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M content/test/test_render_view_host_factory.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/test/test_render_view_host_factory.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Charlie Reis
LGTM
7 years, 6 months ago (2013-06-05 18:43:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/15799009/1
7 years, 6 months ago (2013-06-05 19:32:57 UTC) #2
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 6 months ago (2013-06-06 03:08:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/15799009/1
7 years, 6 months ago (2013-06-06 03:15:29 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 03:48:52 UTC) #5
Message was sent while issue was closed.
Change committed as 204409

Powered by Google App Engine
This is Rietveld 408576698