Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1648403002: Move base/prefs to components/prefs (Closed)

Created:
4 years, 10 months ago by brettw
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move base/prefs to components/prefs This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups. The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller. The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts. json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files. BUG= Committed: https://crrev.com/deb824cd36c02a93854537d70e1853cb9f1c55b9 Cr-Commit-Position: refs/heads/master@{#372494}

Patch Set 1 #

Patch Set 2 : GYP #

Patch Set 3 : #

Patch Set 4 : Fix build #

Patch Set 5 : Inline test data #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -9321 lines) Patch
M base/BUILD.gn View 1 2 3 chunks +7 lines, -84 lines 0 comments Download
M base/base.gyp View 1 2 3 4 3 chunks +0 lines, -89 lines 0 comments Download
A base/prefs/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
D base/prefs/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D base/prefs/README View 1 chunk +0 lines, -6 lines 0 comments Download
M base/prefs/base_prefs_export.h View 1 chunk +3 lines, -25 lines 0 comments Download
M base/prefs/default_pref_store.h View 1 chunk +3 lines, -49 lines 0 comments Download
D base/prefs/default_pref_store.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D base/prefs/default_pref_store_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M base/prefs/json_pref_store.h View 1 chunk +3 lines, -225 lines 0 comments Download
D base/prefs/json_pref_store.cc View 1 chunk +0 lines, -537 lines 0 comments Download
D base/prefs/json_pref_store_unittest.cc View 1 chunk +0 lines, -965 lines 0 comments Download
M base/prefs/mock_pref_change_callback.h View 1 chunk +3 lines, -47 lines 0 comments Download
D base/prefs/mock_pref_change_callback.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M base/prefs/overlay_user_pref_store.h View 1 chunk +3 lines, -85 lines 0 comments Download
D base/prefs/overlay_user_pref_store.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D base/prefs/overlay_user_pref_store_unittest.cc View 1 chunk +0 lines, -292 lines 0 comments Download
M base/prefs/persistent_pref_store.h View 1 chunk +3 lines, -73 lines 0 comments Download
M base/prefs/pref_change_registrar.h View 1 chunk +3 lines, -77 lines 0 comments Download
D base/prefs/pref_change_registrar.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D base/prefs/pref_change_registrar_unittest.cc View 1 chunk +0 lines, -198 lines 0 comments Download
M base/prefs/pref_filter.h View 1 chunk +3 lines, -51 lines 0 comments Download
M base/prefs/pref_member.h View 1 chunk +3 lines, -351 lines 0 comments Download
D base/prefs/pref_member.cc View 1 chunk +0 lines, -223 lines 0 comments Download
D base/prefs/pref_member_unittest.cc View 1 chunk +0 lines, -325 lines 0 comments Download
M base/prefs/pref_notifier.h View 1 chunk +3 lines, -22 lines 0 comments Download
M base/prefs/pref_notifier_impl.h View 1 chunk +3 lines, -70 lines 0 comments Download
D base/prefs/pref_notifier_impl.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D base/prefs/pref_notifier_impl_unittest.cc View 1 chunk +0 lines, -222 lines 0 comments Download
M base/prefs/pref_observer.h View 1 chunk +3 lines, -17 lines 0 comments Download
M base/prefs/pref_registry.h View 1 chunk +3 lines, -85 lines 0 comments Download
D base/prefs/pref_registry.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M base/prefs/pref_registry_simple.h View 1 chunk +3 lines, -87 lines 0 comments Download
D base/prefs/pref_registry_simple.cc View 1 chunk +0 lines, -160 lines 0 comments Download
M base/prefs/pref_service.h View 1 chunk +3 lines, -381 lines 0 comments Download
D base/prefs/pref_service.cc View 1 chunk +0 lines, -616 lines 0 comments Download
M base/prefs/pref_service_factory.h View 1 chunk +3 lines, -87 lines 0 comments Download
D base/prefs/pref_service_factory.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D base/prefs/pref_service_unittest.cc View 1 chunk +0 lines, -430 lines 0 comments Download
M base/prefs/pref_store.h View 1 chunk +3 lines, -59 lines 0 comments Download
D base/prefs/pref_store.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M base/prefs/pref_store_observer_mock.h View 1 chunk +3 lines, -31 lines 0 comments Download
D base/prefs/pref_store_observer_mock.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M base/prefs/pref_value_map.h View 1 chunk +3 lines, -87 lines 0 comments Download
D base/prefs/pref_value_map.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D base/prefs/pref_value_map_unittest.cc View 1 chunk +0 lines, -135 lines 0 comments Download
M base/prefs/pref_value_store.h View 1 chunk +3 lines, -256 lines 0 comments Download
D base/prefs/pref_value_store.cc View 1 chunk +0 lines, -290 lines 0 comments Download
D base/prefs/pref_value_store_unittest.cc View 1 chunk +0 lines, -670 lines 0 comments Download
M base/prefs/scoped_user_pref_update.h View 1 chunk +3 lines, -104 lines 0 comments Download
D base/prefs/scoped_user_pref_update.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D base/prefs/scoped_user_pref_update_unittest.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M base/prefs/testing_pref_service.h View 1 chunk +3 lines, -192 lines 0 comments Download
D base/prefs/testing_pref_service.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M base/prefs/testing_pref_store.h View 1 chunk +3 lines, -110 lines 0 comments Download
D base/prefs/testing_pref_store.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M base/prefs/value_map_pref_store.h View 1 chunk +3 lines, -53 lines 0 comments Download
D base/prefs/value_map_pref_store.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M base/prefs/writeable_pref_store.h View 1 chunk +3 lines, -68 lines 0 comments Download
D base/test/data/prefs/invalid.json View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D base/test/data/prefs/read.json View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
D base/test/data/prefs/write.golden.json View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 2 3 4 5 3 chunks +2 lines, -2 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill.gypi View 1 2 3 4 5 6 chunks +3 lines, -3 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 4 chunks +15 lines, -1 line 0 comments Download
M components/content_settings.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M components/domain_reliability.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/flags_ui.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/history.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M components/invalidation.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M components/keyed_service.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/metrics.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/policy/policy_browser.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M components/policy/policy_common.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M components/pref_registry.gypi View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A components/prefs/BUILD.gn View 1 2 3 1 chunk +106 lines, -0 lines 0 comments Download
A + components/prefs/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/base_prefs_export.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/default_pref_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/default_pref_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/default_pref_store_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/json_pref_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/json_pref_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/json_pref_store_unittest.cc View 1 2 3 4 22 chunks +100 lines, -103 lines 0 comments Download
A + components/prefs/mock_pref_change_callback.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/mock_pref_change_callback.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/overlay_user_pref_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/overlay_user_pref_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/overlay_user_pref_store_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/persistent_pref_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_change_registrar.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_change_registrar.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_change_registrar_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_filter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_member.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_member.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_member_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_notifier.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_notifier_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_notifier_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_notifier_impl_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_registry.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_registry.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_registry_simple.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_registry_simple.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_service.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_service.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_service_factory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_service_factory.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_service_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_store_observer_mock.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_store_observer_mock.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_value_map.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_value_map.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_value_map_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_value_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_value_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/pref_value_store_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/prefs/prefs.gyp View 1 2 3 4 5 6 1 chunk +87 lines, -0 lines 0 comments Download
A + components/prefs/scoped_user_pref_update.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/scoped_user_pref_update.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/scoped_user_pref_update_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/testing_pref_service.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/testing_pref_service.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/testing_pref_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/testing_pref_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/value_map_pref_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/value_map_pref_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/prefs/writeable_pref_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/proximity_auth.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/proxy_config.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/signin.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M components/ssl_config.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/startup_metric_utils.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/syncable_prefs.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/user_prefs.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/variations.gypi View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/wallpaper.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 5 3 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M net/net.gyp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M net/net_common.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M rlz/rlz.gyp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 34 (20 generated)
brettw
You should be able to just check the build files and json_pref_store_unittest.cc. The rest of ...
4 years, 10 months ago (2016-01-29 18:47:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648403002/40001
4 years, 10 months ago (2016-01-29 18:49:15 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/14826) android_chromium_gn_compile_dbg on ...
4 years, 10 months ago (2016-01-29 18:55:25 UTC) #7
jam
lgtm for others reading: we didn't have components when prefs was moved. Now that we ...
4 years, 10 months ago (2016-01-29 18:57:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648403002/60001
4 years, 10 months ago (2016-01-29 19:03:37 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/165426)
4 years, 10 months ago (2016-01-29 19:12:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648403002/80001
4 years, 10 months ago (2016-01-29 20:58:12 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/165511)
4 years, 10 months ago (2016-01-29 21:14:58 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648403002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648403002/100001
4 years, 10 months ago (2016-01-29 21:39:52 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/165548)
4 years, 10 months ago (2016-01-29 21:51:55 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648403002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648403002/120001
4 years, 10 months ago (2016-01-29 21:53:48 UTC) #29
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 10 months ago (2016-01-30 00:38:07 UTC) #31
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/deb824cd36c02a93854537d70e1853cb9f1c55b9 Cr-Commit-Position: refs/heads/master@{#372494}
4 years, 10 months ago (2016-01-30 00:39:13 UTC) #33
joedow
4 years, 10 months ago (2016-01-30 00:53:51 UTC) #34
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1645073005/ by joedow@chromium.org.

The reason for reverting is: Reverting due to failure on iOS builder:
https://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/bui....

Powered by Google App Engine
This is Rietveld 408576698