Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1994)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1652573002: Update GN build files for new prefs location. (Closed)

Created:
4 years, 10 months ago by brettw
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, msramek+watch_chromium.org, sadrul, oshima+watch_chromium.org, zea+watch_chromium.org, vmpstr+watch_chromium.org, browser-components-watch_chromium.org, bondd+autofillwatch_chromium.org, noyau+watch_chromium.org, markusheintz_, wifiprefetch-reviews_google.com, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, lcwu+watch_chromium.org, jam, raymes+watch_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, wjmaclean, asvitkine+watch_chromium.org, kalyank, gunsch+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, tfarina, maxbogue+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@presf_move
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update GN build files for new prefs location. Updates references from //base:prefs to //components/prefs/ TBR=jam@chromium.org Committed: https://crrev.com/9f7802a28dbf16b0f28e0bf65bbc9c004d8a129a Cr-Commit-Position: refs/heads/master@{#372540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -148 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chromecast/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chromecast/browser/metrics/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 4 chunks +3 lines, -5 lines 0 comments Download
M components/bookmarks/browser/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M components/bookmarks/managed/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M components/browser_sync/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/cronet/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M components/dom_distiller/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M components/feedback/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/cpp/prefs/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/flags_ui/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/google/core/browser/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/invalidation/impl/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/keyed_service/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/network_time/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M components/password_manager/content/browser/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/password_manager/sync/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M components/precache/content/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/precache/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/pref_registry/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M components/prefs/BUILD.gn View 2 chunks +31 lines, -0 lines 0 comments Download
M components/proximity_auth/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/ble/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/webui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/proxy_config/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/rappor/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M components/search_engines/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/security_interstitials/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M components/signin/ios/browser/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M components/ssl_config/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/startup_metric_utils/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_bookmarks/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_sessions/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M components/syncable_prefs/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M components/translate/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/translate/ios/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ui/zoom/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/user_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/user_prefs/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/user_prefs/tracked/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M components/variations/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/service/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/wallpaper/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/web_cache/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/web_resource/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/wallpaper/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M rlz/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libaddressinput/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1648403002 Patch 120001

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652573002/1
4 years, 10 months ago (2016-01-30 00:13:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-30 01:34:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652573002/1
4 years, 10 months ago (2016-01-30 06:33:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-30 06:40:25 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 06:41:20 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9f7802a28dbf16b0f28e0bf65bbc9c004d8a129a
Cr-Commit-Position: refs/heads/master@{#372540}

Powered by Google App Engine
This is Rietveld 408576698