Move base/prefs to components/prefs

Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups.

The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts.

json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files.

BUG=

Committed: https://crrev.com/deb824cd36c02a93854537d70e1853cb9f1c55b9
Cr-Commit-Position: refs/heads/master@{#372494}

[brettw, 2016-01-29 18:47:40]

brettw@chromium.org changed reviewers:
+ jam@chromium.org

[brettw, 2016-01-29 18:47:41]

You should be able to just check the build files and
json_pref_store_unittest.cc. The rest of the code should just be moved or
trivial forwarding headers.

[brettw, 2016-01-29 18:48:05]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 18:49:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648403002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648403002/40001

[brettw, 2016-01-29 18:52:04]

Description was changed from

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

BUG=
==========

to

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

BUG=
==========

[commit-bot: I haz the power, 2016-01-29 18:55:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 18:55:25]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2016-01-29 18:57:36]

lgtm

for others reading: we didn't have components when prefs was moved. Now that we
do, it's the place where this belongs. Brett checked with an owner who was
supportive (Pam)

[brettw, 2016-01-29 19:01:28]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-01-29 19:01:28]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1648403002/#ps60001
(title: "Fix build")

[commit-bot: I haz the power, 2016-01-29 19:03:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648403002/60001

[commit-bot: I haz the power, 2016-01-29 19:12:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 19:12:56]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[brettw, 2016-01-29 20:41:59]

Description was changed from

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

BUG=
==========

to

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The GYP build has been updated to point to the new location because the
forwarding headers generated a .gyp file cycle. The GN build uses forwarding
targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

BUG=
==========

[brettw, 2016-01-29 20:51:00]

Description was changed from

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The GYP build has been updated to point to the new location because the
forwarding headers generated a .gyp file cycle. The GN build uses forwarding
targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

BUG=
==========

to

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The GYP build has been updated to point to the new location because the
forwarding headers generated a .gyp file cycle. The GN build uses forwarding
targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

json_pref_store_unittests.cc also depended on the files il base/test/data/prefs.
Rather than worry about updating all the isolates and such, this just adds the
data inline and avoids having separate test files.

BUG=
==========

[brettw, 2016-01-29 20:55:02]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-01-29 20:55:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1648403002/#ps80001
(title: "Inline test data")

[commit-bot: I haz the power, 2016-01-29 20:58:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648403002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648403002/80001

[commit-bot: I haz the power, 2016-01-29 21:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 21:14:58]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[brettw, 2016-01-29 21:37:36]

Description was changed from

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The GYP build has been updated to point to the new location because the
forwarding headers generated a .gyp file cycle. The GN build uses forwarding
targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

json_pref_store_unittests.cc also depended on the files il base/test/data/prefs.
Rather than worry about updating all the isolates and such, this just adds the
data inline and avoids having separate test files.

BUG=
==========

to

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The GYP build has been updated to point to the new location because the
forwarding headers generated a .gyp file cycle. Avoiding a cycle with
libaddressinput is why prefs is a separate .gyp from most of the rest of the
components. The GN build uses forwarding targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

json_pref_store_unittests.cc also depended on the files il base/test/data/prefs.
Rather than worry about updating all the isolates and such, this just adds the
data inline and avoids having separate test files.

BUG=
==========

[brettw, 2016-01-29 21:39:05]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-01-29 21:39:06]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1648403002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-01-29 21:39:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648403002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648403002/100001

[commit-bot: I haz the power, 2016-01-29 21:51:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 21:51:55]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[brettw, 2016-01-29 21:52:48]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-01-29 21:52:49]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1648403002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-01-29 21:53:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648403002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648403002/120001

[commit-bot: I haz the power, 2016-01-30 00:38:05]

Description was changed from

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The GYP build has been updated to point to the new location because the
forwarding headers generated a .gyp file cycle. Avoiding a cycle with
libaddressinput is why prefs is a separate .gyp from most of the rest of the
components. The GN build uses forwarding targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

json_pref_store_unittests.cc also depended on the files il base/test/data/prefs.
Rather than worry about updating all the isolates and such, this just adds the
data inline and avoids having separate test files.

BUG=
==========

to

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The GYP build has been updated to point to the new location because the
forwarding headers generated a .gyp file cycle. Avoiding a cycle with
libaddressinput is why prefs is a separate .gyp from most of the rest of the
components. The GN build uses forwarding targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

json_pref_store_unittests.cc also depended on the files il base/test/data/prefs.
Rather than worry about updating all the isolates and such, this just adds the
data inline and avoids having separate test files.

BUG=
==========

[commit-bot: I haz the power, 2016-01-30 00:38:07]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-01-30 00:39:12]

Description was changed from

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The GYP build has been updated to point to the new location because the
forwarding headers generated a .gyp file cycle. Avoiding a cycle with
libaddressinput is why prefs is a separate .gyp from most of the rest of the
components. The GN build uses forwarding targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

json_pref_store_unittests.cc also depended on the files il base/test/data/prefs.
Rather than worry about updating all the isolates and such, this just adds the
data inline and avoids having separate test files.

BUG=
==========

to

==========
Move base/prefs to components/prefs

This change is the minimal move change. It does not update namespaces or
includes. Forwarding headers and targets exist to map to the new location. The
namespaces, include guards, and references to these files will be updated in
follow-ups.

The GYP build has been updated to point to the new location because the
forwarding headers generated a .gyp file cycle. Avoiding a cycle with
libaddressinput is why prefs is a separate .gyp from most of the rest of the
components. The GN build uses forwarding targets to keep the change smaller.

The json pref store unit tests had to be updated because of the way that they
used histograms conflicted with the hsitogram setup of the components unittests.
Fortunately, there's a HistogramTester helper for this case, so this patch uses
it in for the moved test in place of manually checking histogram counts.

json_pref_store_unittests.cc also depended on the files il base/test/data/prefs.
Rather than worry about updating all the isolates and such, this just adds the
data inline and avoids having separate test files.

BUG=

Committed: https://crrev.com/deb824cd36c02a93854537d70e1853cb9f1c55b9
Cr-Commit-Position: refs/heads/master@{#372494}
==========

[commit-bot: I haz the power, 2016-01-30 00:39:13]

Patchset 7 (id:??) landed as
https://crrev.com/deb824cd36c02a93854537d70e1853cb9f1c55b9
Cr-Commit-Position: refs/heads/master@{#372494}

[joedow, 2016-01-30 00:53:51]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1645073005/ by joedow@chromium.org.

The reason for reverting is: Reverting due to failure on iOS builder:
https://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/bui....