clang tools: Add --bootstrap to the documentation for update.py

clang tools: Add --bootstrap to the documentation for update.py

This lets us build the clang tools with clang not gcc, which appears to
have bugs!

Also work around the gcc bug in one place we know it happens anyways,
just because.

R=dcheng
BUG=580745
Committed: https://crrev.com/30d0f8c92a47b357789076692ec2eeb571bf312e
Cr-Commit-Position: refs/heads/master@{#371933}

[danakj, 2016-01-27 23:35:23]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 23:37:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1647733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1647733002/1

[dcheng, 2016-01-27 23:46:15]

https://codereview.chromium.org/1647733002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1647733002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:117: if (c)
This gives me the heebie jeebies. I feel like we shouldn't check in code like
this, because if we can't trust the compiler, then there's basically nothing we
can do, right? We basically don't have a way to guarantee that this will work
since it's really hard to test.

[danakj, 2016-01-27 23:51:01]

https://codereview.chromium.org/1647733002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1647733002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:117: if (c)
On 2016/01/27 23:46:15, dcheng wrote:
> This gives me the heebie jeebies. I feel like we shouldn't check in code like
> this, because if we can't trust the compiler, then there's basically nothing
we
> can do, right? We basically don't have a way to guarantee that this will work
> since it's really hard to test.

Ya, I'm sure there's other bugs happening elsewhere too, heh. I just don't like
leaving the one I know here malfunctioning, just cuz.. you think it's better to
cover our eyes on this one place and just say don't use gcc?

[commit-bot: I haz the power, 2016-01-28 00:11:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 00:11:00]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-01-28 00:14:30]

I guess I don't care enough about the tool to take a hard stance. It just feels
like we're going to play whack-a-mole if we can't trust the compiler, and I love
moles.

lgtm

[danakj, 2016-01-28 00:17:13]

On Wed, Jan 27, 2016 at 4:14 PM, <dcheng@chromium.org> wrote:

> I guess I don't care enough about the tool to take a hard stance. It just
feels
> like we're going to play whack-a-mole if we can't trust the compiler, and I
love
> moles.
>
>
Haha, ya, I don't actually want to find any more gcc bugs, and will not be
attempting to..


>
> lgtm
> https://codereview.chromium.org/1647733002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-01-28 00:17:18]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-01-28 00:18:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1647733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1647733002/1

[commit-bot: I haz the power, 2016-01-28 00:26:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-28 00:28:01]

Description was changed from

==========
clang tools: Add --bootstrap to the documentation for update.py

This lets us build the clang tools with clang not gcc, which appears to
have bugs!

Also work around the gcc bug in one place we know it happens anyways,
just because.

R=dcheng
BUG=580745
==========

to

==========
clang tools: Add --bootstrap to the documentation for update.py

This lets us build the clang tools with clang not gcc, which appears to
have bugs!

Also work around the gcc bug in one place we know it happens anyways,
just because.

R=dcheng
BUG=580745

Committed: https://crrev.com/30d0f8c92a47b357789076692ec2eeb571bf312e
Cr-Commit-Position: refs/heads/master@{#371933}
==========

[commit-bot: I haz the power, 2016-01-28 00:28:02]

Patchset 1 (id:??) landed as
https://crrev.com/30d0f8c92a47b357789076692ec2eeb571bf312e
Cr-Commit-Position: refs/heads/master@{#371933}