Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

Issue 1647733002: clang tools: Add --bootstrap to the documentation for update.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « docs/clang_tool_refactoring.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
diff --git a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
index db208abc2f762e0a7848ddb5f3700cb21743c46f..08ce7b7871d365c8a0fd54abea57029fba727aa8 100644
--- a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
+++ b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
@@ -111,7 +111,10 @@ bool GetNameForDecl(const clang::FieldDecl& decl,
original_name.substr(strlen(kBlinkFieldPrefix)));
// The few examples I could find used struct-style naming with no `_` suffix
// for unions.
- if (decl.getParent()->isClass())
+ bool c = decl.getParent()->isClass();
+ // There appears to be a GCC bug that makes this branch incorrectly if we
+ // don't use a temp variable!! Clang works right. crbug.com/580745
+ if (c)
dcheng 2016/01/27 23:46:15 This gives me the heebie jeebies. I feel like we s
danakj 2016/01/27 23:51:01 Ya, I'm sure there's other bugs happening elsewher
name += '_';
return true;
}
« no previous file with comments | « docs/clang_tool_refactoring.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698