docs/clang_tool_refactoring.md - Issue 1647733002: clang tools: Add --bootstrap to the documentation for update.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: docs/clang_tool_refactoring.md

Issue 1647733002: clang tools: Add --bootstrap to the documentation for update.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp » ('j') | tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: docs/clang_tool_refactoring.md

diff --git a/docs/clang_tool_refactoring.md b/docs/clang_tool_refactoring.md

index 3d9c9edf5f71bfb8075948a46ca84f2e70517758..ef7faabe97493051af6e0d90a7b7d0625ec6a5e3 100644

--- a/docs/clang_tool_refactoring.md

+++ b/docs/clang_tool_refactoring.md

@@ -97,7 +97,7 @@ doesn't work well for Chromium:

Synopsis:

```shell

-tools/clang/scripts/update.py --force-local-build --without-android \

+tools/clang/scripts/update.py --bootstrap --force-local-build --without-android \

--tools blink_gc_plugin plugins rewrite_to_chrome_style

```

@@ -109,6 +109,9 @@ subdirectories in

[//tools/clang](https://chromium.googlesource.com/chromium/src/+/master/tools/clang).

Generally, `--tools` should always include `blink_gc_plugin` and `plugins`: otherwise, Chromium won't build.

+It is important to use --bootstrap as there appear to be [bugs](https://crbug.com/580745)

+in the clang library this script produces if you build it with gcc, which is the default.

## Running

First, build all chromium targets to avoid failures due to missing dependecies

that are generated as part of the build:

« no previous file with comments | « no previous file | tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp » ('j') | tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp » ('J')