Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/AdvancedApp.js

Issue 1647653003: [DevTools] Remove old responsive design v1 code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/AdvancedApp.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/AdvancedApp.js b/third_party/WebKit/Source/devtools/front_end/main/AdvancedApp.js
index 9051edeb31dad57edf5154da8d4c992ea925b76f..0d834162ca6abc3ed726fcc9b3754b46c51d8d42 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/AdvancedApp.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/AdvancedApp.js
@@ -28,10 +28,7 @@ WebInspector.AdvancedApp.prototype = {
this._inspectedPagePlaceholder = new WebInspector.InspectedPagePlaceholder();
this._inspectedPagePlaceholder.addEventListener(WebInspector.InspectedPagePlaceholder.Events.Update, this._onSetInspectedPageBounds.bind(this), this);
- if (Runtime.experiments.isEnabled("deviceMode"))
- this._responsiveDesignView = new WebInspector.DeviceModeView.Wrapper(this._inspectedPagePlaceholder);
- else
- this._responsiveDesignView = new WebInspector.ResponsiveDesignView(this._inspectedPagePlaceholder);
+ this._deviceModeView = new WebInspector.DeviceModeView.Wrapper(this._inspectedPagePlaceholder);
WebInspector.dockController.addEventListener(WebInspector.DockController.Events.BeforeDockSideChanged, this._onBeforeDockSideChange, this);
WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._onDockSideChange, this);
@@ -77,7 +74,7 @@ WebInspector.AdvancedApp.prototype = {
this._toolboxRootView = new WebInspector.RootView();
this._toolboxRootView.attachToDocument(toolboxDocument);
- this._updateResponsiveDesignView();
+ this._updateDeviceModeView();
if (this._presentUICallback) {
var callback = this._presentUICallback;
@@ -86,14 +83,12 @@ WebInspector.AdvancedApp.prototype = {
}
},
- _updateResponsiveDesignView: function()
+ _updateDeviceModeView: function()
{
if (this._isDocked())
- this._rootSplitWidget.setMainWidget(this._responsiveDesignView);
+ this._rootSplitWidget.setMainWidget(this._deviceModeView);
else if (this._toolboxRootView)
- this._responsiveDesignView.show(this._toolboxRootView.element);
- if (!Runtime.experiments.isEnabled("deviceMode") && (this._isDocked() || this._toolboxRootView))
- this._responsiveDesignView.updatePageResizer();
+ this._deviceModeView.show(this._toolboxRootView.element);
},
/**
@@ -115,7 +110,7 @@ WebInspector.AdvancedApp.prototype = {
*/
_onDockSideChange: function(event)
{
- this._updateResponsiveDesignView();
+ this._updateDeviceModeView();
var toDockSide = event ? /** @type {string} */ (event.data.to) : WebInspector.dockController.dockSide();
if (toDockSide === WebInspector.DockController.State.Undocked) {

Powered by Google App Engine
This is Rietveld 408576698