Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1650483003: [interpreter] Deprecate notion of an unreachable environment. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-cleanup-branch-analysis
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Deprecate notion of an unreachable environment. The notion of an unreachable environment is useful for a recursive descent iteration (e.g. over an AST) where nodes are created on the ascent path as well. For a flat iteration (e.g. over bytecode stream) environments become unreachable at the end of a visitation function. Hence any unreachable path can be represented by nulling the tracked environment completely. This further reduces the number of redundant nodes being created. R=oth@chromium.org Committed: https://crrev.com/7d07a6c48901db92f3e6fd1cc84b55b8453d38f9 Cr-Commit-Position: refs/heads/master@{#33639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -71 lines) Patch
M src/compiler/bytecode-graph-builder.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 8 chunks +46 lines, -67 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 10 months ago (2016-01-29 14:52:17 UTC) #3
oth
lgtm. Thank you for producing this run in manageable bitesized pieces.
4 years, 10 months ago (2016-02-01 09:09:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650483003/1
4 years, 10 months ago (2016-02-01 11:54:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 12:17:56 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 12:18:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d07a6c48901db92f3e6fd1cc84b55b8453d38f9
Cr-Commit-Position: refs/heads/master@{#33639}

Powered by Google App Engine
This is Rietveld 408576698