third_party/instrumented_libraries/scripts/download_build_install.py - Issue 1646813004: Reassign all of earthdok's TODOs and remove from OWNERS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/instrumented_libraries/scripts/download_build_install.py

Issue 1646813004: Reassign all of earthdok's TODOs and remove from OWNERS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reassign Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/instrumented_libraries/instrumented_libraries.gyp ('k') | third_party/instrumented_libraries/scripts/fix_rpaths.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/instrumented_libraries/scripts/download_build_install.py

diff --git a/third_party/instrumented_libraries/scripts/download_build_install.py b/third_party/instrumented_libraries/scripts/download_build_install.py

index 56c4014914d1ca626bf399ea93e2814b109adacc..9902b2bd696435a8e410c57792b9a2df89d6902d 100755

--- a/third_party/instrumented_libraries/scripts/download_build_install.py

+++ b/third_party/instrumented_libraries/scripts/download_build_install.py

@@ -183,7 +183,7 @@ class InstrumentedPackageBuilder(object):

self.shell_call('rm -rf %s' % self._working_dir)

def fix_rpaths(self, directory):

- # TODO(earthdok): reimplement fix_rpaths.sh in Python.

+ # TODO(eugenis): reimplement fix_rpaths.sh in Python.

script = real_path('scripts/fix_rpaths.sh')

self.shell_call("%s %s" % (script, directory))