third_party/instrumented_libraries/instrumented_libraries.gyp - Issue 1646813004: Reassign all of earthdok's TODOs and remove from OWNERS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/instrumented_libraries/instrumented_libraries.gyp

Issue 1646813004: Reassign all of earthdok's TODOs and remove from OWNERS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reassign Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « printing/backend/print_backend_cups.cc ('k') | third_party/instrumented_libraries/scripts/download_build_install.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/instrumented_libraries/instrumented_libraries.gyp

diff --git a/third_party/instrumented_libraries/instrumented_libraries.gyp b/third_party/instrumented_libraries/instrumented_libraries.gyp

index 54aefa85d5851d3fe9e93611044d15370fe220dd..e6dbe692373f39d9203d23e5cce22ec276bfd23e 100644

--- a/third_party/instrumented_libraries/instrumented_libraries.gyp

+++ b/third_party/instrumented_libraries/instrumented_libraries.gyp

@@ -530,7 +530,7 @@

{

'package_name': 'nss',

'dependencies=': [

- # TODO(earthdok): get rid of this dependency

+ # TODO(eugenis): get rid of this dependency

'<(_sanitizer_type)-libnspr4',

'patch': 'patches/nss.diff',

@@ -630,7 +630,7 @@

'--disable-static',

# Without this flag there's a linking step that doesn't honor LDFLAGS

# and fails.

- # TODO(earthdok): find a better fix.

+ # TODO(eugenis): find a better fix.

'--disable-gudev'

'pre_build': 'scripts/pre-build/udev.sh',

@@ -726,7 +726,7 @@

'--enable-gtk-doc',

# --enable-introspection introduces a build step that attempts to run

# a just-built binary and crashes. Vala requires introspection.

- # TODO(earthdok): find a better fix.

+ # TODO(eugenis): find a better fix.

'--disable-introspection',

'--disable-vala',

« no previous file with comments | « printing/backend/print_backend_cups.cc ('k') | third_party/instrumented_libraries/scripts/download_build_install.py » ('j') | no next file with comments »