third_party/instrumented_libraries/scripts/fix_rpaths.sh - Issue 1646813004: Reassign all of earthdok's TODOs and remove from OWNERS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/instrumented_libraries/scripts/fix_rpaths.sh

Issue 1646813004: Reassign all of earthdok's TODOs and remove from OWNERS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reassign Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/instrumented_libraries/scripts/download_build_install.py ('k') | third_party/instrumented_libraries/scripts/install-build-deps.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/instrumented_libraries/scripts/fix_rpaths.sh

diff --git a/third_party/instrumented_libraries/scripts/fix_rpaths.sh b/third_party/instrumented_libraries/scripts/fix_rpaths.sh

index 578243f4301386fa7178e98806bf4f23407a3e0e..51362a864e8d7bccfadae2e64665725c702a8168 100755

--- a/third_party/instrumented_libraries/scripts/fix_rpaths.sh

+++ b/third_party/instrumented_libraries/scripts/fix_rpaths.sh

@@ -11,7 +11,7 @@ function fix_rpath {

if [ -w "$1" ]

then

# Only attempt to fix RPATH if the entry actually exists.

- # FIXME(earthdok): find out why zlib1g on Precise doesn't get RPATH set.

+ # FIXME(eugenis): find out why zlib1g on Precise doesn't get RPATH set.

if chrpath -l $1

then

echo "fix_rpaths.sh: fixing $1"

@@ -19,7 +19,7 @@ function fix_rpath {

| sed s/RPATH=//g) $1

else

- # FIXME(earthdok): libcups2 DSOs are created non-writable, causing this

+ # FIXME(eugenis): libcups2 DSOs are created non-writable, causing this

# script to fail. As a temporary measure, ignore non-writable files.

echo "fix_rpaths.sh: skipping non-writable file $1"