Issue 164613002: Revert 251094 "Revert 250826 "Remove Profile dependency from app..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164613002: Revert 251094 "Revert 250826 "Remove Profile dependency from app..." (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)

Modified:
6 years, 10 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 251094 "Revert 250826 "Remove Profile dependency from app..." Speculative re-land. Sync tests are passing now, but we're not sure which revert fixed them. Let's see if this makes the tree red again or not. > Revert 250826 "Remove Profile dependency from apps::ShellWindow" > > Speculative revert for failures: > > http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201 > > > Remove Profile dependency from apps::ShellWindow > > > > Part of the effort to remove src/chrome dependencies from src/{apps, extensions} > > > > BUG=341690 > > TBR=tapted@chromium.org,stevenjb@chromium.org > > > > Review URL: https://codereview.chromium.org/157813007 > > TBR=rockot@chromium.org > > Review URL: https://codereview.chromium.org/163913004 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251112

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+166 lines, -100 lines)			Patch
M	trunk/src/apps/app_lifetime_monitor.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/apps/app_shim/app_shim_handler_mac.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/apps/app_shim/extension_app_shim_handler_mac.cc	View	4 chunks	+12 lines, -7 lines	0 comments	Download
M	trunk/src/apps/app_window_contents.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	trunk/src/apps/app_window_contents.cc	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	trunk/src/apps/shell/browser/shell_extensions_browser_client.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/apps/shell/browser/shell_extensions_browser_client.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/src/apps/shell_window.h	View	7 chunks	+11 lines, -7 lines	0 comments	Download
M	trunk/src/apps/shell_window.cc	View	18 chunks	+51 lines, -30 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/app_window/app_window_api.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/tabs/ash_panel_contents.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/tabs/ash_panel_contents.cc	View	3 chunks	+9 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/chrome_extensions_browser_client.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/chrome_extensions_browser_client.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/apps/chrome_shell_window_delegate.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/apps/chrome_shell_window_delegate.cc	View	6 chunks	+8 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/ash/launcher/multi_profile_shell_window_launcher_controller.cc	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/gtk/apps/native_app_window_gtk.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/gtk/apps/native_app_window_gtk.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/apps/native_app_window_views.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/apps/native_app_window_views.cc	View	2 chunks	+12 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/apps/native_app_window_views_win.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	trunk/src/extensions/browser/extensions_browser_client.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexei Svitkine (slow)

6 years, 10 months ago (2014-02-13 20:26:51 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r251112.

Expand Messages | Collapse Messages