Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Issue 163913004: Revert 250826 "Remove Profile dependency from apps::ShellWindow" (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 250826 "Remove Profile dependency from apps::ShellWindow" Speculative revert for failures: http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201 > Remove Profile dependency from apps::ShellWindow > > Part of the effort to remove src/chrome dependencies from src/{apps, extensions} > > BUG=341690 > TBR=tapted@chromium.org,stevenjb@chromium.org > > Review URL: https://codereview.chromium.org/157813007 TBR=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -166 lines) Patch
M trunk/src/apps/app_lifetime_monitor.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/apps/app_shim/app_shim_handler_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/apps/app_shim/extension_app_shim_handler_mac.cc View 4 chunks +7 lines, -12 lines 0 comments Download
M trunk/src/apps/app_window_contents.h View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/apps/app_window_contents.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/apps/shell/browser/shell_extensions_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/apps/shell/browser/shell_extensions_browser_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/apps/shell_window.h View 7 chunks +7 lines, -11 lines 0 comments Download
M trunk/src/apps/shell_window.cc View 18 chunks +30 lines, -51 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/app_window/app_window_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/tabs/ash_panel_contents.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/tabs/ash_panel_contents.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/extensions/chrome_extensions_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/apps/chrome_shell_window_delegate.h View 2 chunks +3 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/apps/chrome_shell_window_delegate.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/multi_profile_shell_window_launcher_controller.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm View 1 chunk +2 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/apps/native_app_window_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/apps/native_app_window_gtk.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/apps/native_app_window_views.h View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/apps/native_app_window_views.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/apps/native_app_window_views_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/extensions/browser/extensions_browser_client.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
6 years, 10 months ago (2014-02-13 18:54:58 UTC) #1
Alexei Svitkine (slow)
Committed patchset #1 manually as r251094 (tree was closed).
6 years, 10 months ago (2014-02-13 18:55:22 UTC) #2
Alexei Svitkine (slow)
Will recommit if I confirm this isn't the cause. On Thu, Feb 13, 2014 at ...
6 years, 10 months ago (2014-02-13 19:05:44 UTC) #3
Ken Rockot(use gerrit already)
6 years, 10 months ago (2014-02-13 19:29:26 UTC) #4
No worries. I'm fairly confident that this couldn't be causing those
failures, but thanks for the update!


On Thu, Feb 13, 2014 at 11:05 AM, Alexei Svitkine
<asvitkine@chromium.org>wrote:

> Will recommit if I confirm this isn't the cause.
>
>
> On Thu, Feb 13, 2014 at 1:55 PM, <asvitkine@chromium.org> wrote:
>
>> Committed patchset #1 manually as r251094 (tree was closed).
>>
>> https://codereview.chromium.org/163913004/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698