Remove Profile dependency from apps::ShellWindow

Remove Profile dependency from apps::ShellWindow

Part of the effort to remove src/chrome dependencies from src/{apps, extensions}

BUG=341690
TBR=tapted@chromium.org,stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250826

[James Cook, 2014-02-12 00:46:40]

LGTM with nits. Nice.

https://codereview.chromium.org/157813007/diff/40001/apps/app_window_contents.h
File apps/app_window_contents.h (right):

https://codereview.chromium.org/157813007/diff/40001/apps/app_window_contents...
apps/app_window_contents.h:20: class BrowserContext;
totally optional nit: I usually don't forward-declare classes that are used in
an interface from which I'm inheriting

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.cc
File apps/shell_window.cc (right):

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.cc#new...
apps/shell_window.cc:1: // Copyright 2014 The Chromium Authors. All rights
reserved.
ditto

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.h
File apps/shell_window.h (right):

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.h#newc...
apps/shell_window.h:1: // Copyright 2014 The Chromium Authors. All rights
reserved.
nit: You don't need to update these when you edit files, only when you create
them.

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.h#newc...
apps/shell_window.h:14: #include "content/public/browser/browser_context.h"
Isn't forward declaring it enough?

https://codereview.chromium.org/157813007/diff/40001/apps/ui/native_app_window.h
File apps/ui/native_app_window.h (right):

https://codereview.chromium.org/157813007/diff/40001/apps/ui/native_app_windo...
apps/ui/native_app_window.h:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
ditto

[Ken Rockot(use gerrit already), 2014-02-12 01:05:45]

Thanks

https://codereview.chromium.org/157813007/diff/40001/apps/app_window_contents.h
File apps/app_window_contents.h (right):

https://codereview.chromium.org/157813007/diff/40001/apps/app_window_contents...
apps/app_window_contents.h:20: class BrowserContext;
On 2014/02/12 00:46:41, James Cook wrote:
> totally optional nit: I usually don't forward-declare classes that are used in
> an interface from which I'm inheriting

I can support that. Done.

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.cc
File apps/shell_window.cc (right):

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.cc#new...
apps/shell_window.cc:1: // Copyright 2014 The Chromium Authors. All rights
reserved.
On 2014/02/12 00:46:41, James Cook wrote:
> ditto

Done.

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.h
File apps/shell_window.h (right):

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.h#newc...
apps/shell_window.h:1: // Copyright 2014 The Chromium Authors. All rights
reserved.
On 2014/02/12 00:46:41, James Cook wrote:
> nit: You don't need to update these when you edit files, only when you create
> them.

Yeah actually I just had this conversation with someone else because I was
wondering what to do.

https://codereview.chromium.org/157813007/diff/40001/apps/shell_window.h#newc...
apps/shell_window.h:14: #include "content/public/browser/browser_context.h"
On 2014/02/12 00:46:41, James Cook wrote:
> Isn't forward declaring it enough?

Yes, oops.

https://codereview.chromium.org/157813007/diff/40001/apps/ui/native_app_window.h
File apps/ui/native_app_window.h (right):

https://codereview.chromium.org/157813007/diff/40001/apps/ui/native_app_windo...
apps/ui/native_app_window.h:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
On 2014/02/12 00:46:41, James Cook wrote:
> ditto

Done.

[Ken Rockot(use gerrit already), 2014-02-12 01:08:47]

Ben, could you please have a look as OWNER?

[benwells, 2014-02-12 05:16:24]

nice, lgtm

[Ken Rockot(use gerrit already), 2014-02-12 17:02:31]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-12 17:03:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/157813007/150001

[Ken Rockot(use gerrit already), 2014-02-12 17:36:38]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2014-02-12 20:27:16]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-12 20:29:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/157813007/580001

[commit-bot: I haz the power, 2014-02-12 23:15:37]

Change committed as 250826

[tapted, 2014-02-17 05:25:59]

Nice CL! my_activity.py told me I was TBR'd so I decided to swing by ;). Left
some comments in case you're doing more around this, but a follow-up isn't
really needed. At some point I think we want src/apps/app_shim to move to
src/chrome/browser/ui/apps/app_shim since it's pretty tied to other browser
things. That is, it might not matter that Profile still has some tendrils in
there.

https://codereview.chromium.org/157813007/diff/580001/apps/app_shim/extension...
File apps/app_shim/extension_app_shim_handler_mac.cc (right):

https://codereview.chromium.org/157813007/diff/580001/apps/app_shim/extension...
apps/app_shim/extension_app_shim_handler_mac.cc:51: void SetAppHidden(Profile*
profile, const std::string& app_id, bool hidden) {
This should be able to take a BrowserContext without issues, cleaning up some of
the call sites

https://codereview.chromium.org/157813007/diff/580001/apps/app_shim/extension...
apps/app_shim/extension_app_shim_handler_mac.cc:241:
Profile::FromBrowserContext(shell_window->browser_context()))
nit: The `FromBrowserContext` cast probably not needed here